Git development
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Toon Claes <toon@iotcl.com>
Cc: Patrick Steinhardt <ps@pks.im>,  git@vger.kernel.org
Subject: Re: [PATCH v2 0/7] refs: remove use of `the_repository`
Date: Wed, 15 Jul 2026 07:38:31 -0700	[thread overview]
Message-ID: <xmqqse5kpbbs.fsf@gitster.g> (raw)
In-Reply-To: <87y0fcfn7v.fsf@emacs.iotcl.com> (Toon Claes's message of "Wed, 15 Jul 2026 14:31:48 +0200")

Toon Claes <toon@iotcl.com> writes:

> Patrick Steinhardt <ps@pks.im> writes:
>
>> Hi,
>>
>> this patch series refactors the ref subsystem to drop uses of
>> `the_repository`. These patches were part of a discarded attempt to
>> make the initialization of the refdb eager. I guess they make sense by
>> themselves though, so here we go.
>>
>> Note that these patches contain a slight tangent to also adapt
>> "worktree.c". This is one of the subsystems that caused problems with
>> eager refdb initialization because of `has_worktrees()`, so I refactored
>> this subsystem while at it.
>
> Changes are all very straightforward and, except from the small comment
> on the commit message of [PATCH 2/7], I approve this series.

Sounds very good.  Thanks.

      reply	other threads:[~2026-07-15 14:38 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-09  8:29 [PATCH 0/7] refs: remove use of `the_repository` Patrick Steinhardt
2026-07-09  8:29 ` [PATCH 1/7] refs/packed: de-globalize handling of "core.packedRefsTimeout" Patrick Steinhardt
2026-07-09 18:52   ` Junio C Hamano
2026-07-10  5:56     ` Patrick Steinhardt
2026-07-09  8:29 ` [PATCH 2/7] refs/packed: drop `USE_THE_REPOSITORY_VARIABLE` Patrick Steinhardt
2026-07-09  8:29 ` [PATCH 3/7] refs/files: " Patrick Steinhardt
2026-07-09  8:29 ` [PATCH 4/7] worktree: refactor code to use available repositories Patrick Steinhardt
2026-07-09  8:29 ` [PATCH 5/7] worktree: pass repository to file-local functions Patrick Steinhardt
2026-07-09  8:29 ` [PATCH 6/7] worktree: pass repository to public functions Patrick Steinhardt
2026-07-09  8:29 ` [PATCH 7/7] refs: remove remaining uses of `the_repository` Patrick Steinhardt
2026-07-09 20:39 ` [PATCH 0/7] refs: remove use " Junio C Hamano
2026-07-10  5:56   ` Patrick Steinhardt
2026-07-10  6:14     ` Patrick Steinhardt
2026-07-10 16:57       ` Junio C Hamano
2026-07-10 20:24         ` Junio C Hamano
2026-07-10 14:48     ` Junio C Hamano
2026-07-15  7:39 ` [PATCH v2 " Patrick Steinhardt
2026-07-15  7:39   ` [PATCH v2 1/7] refs/packed: de-globalize handling of "core.packedRefsTimeout" Patrick Steinhardt
2026-07-15  7:39   ` [PATCH v2 2/7] refs/packed: drop `USE_THE_REPOSITORY_VARIABLE` Patrick Steinhardt
2026-07-15 12:28     ` Toon Claes
2026-07-15  7:39   ` [PATCH v2 3/7] refs/files: " Patrick Steinhardt
2026-07-15  7:39   ` [PATCH v2 4/7] worktree: refactor code to use available repositories Patrick Steinhardt
2026-07-15  7:39   ` [PATCH v2 5/7] worktree: pass repository to file-local functions Patrick Steinhardt
2026-07-15  7:39   ` [PATCH v2 6/7] worktree: pass repository to public functions Patrick Steinhardt
2026-07-15  7:39   ` [PATCH v2 7/7] refs: remove remaining uses of `the_repository` Patrick Steinhardt
2026-07-15 12:31   ` [PATCH v2 0/7] refs: remove use " Toon Claes
2026-07-15 14:38     ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqse5kpbbs.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=ps@pks.im \
    --cc=toon@iotcl.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox