Git development
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Dominik Loidolt <dominik.loidolt@univie.ac.at>
Cc: git@vger.kernel.org,  ps@pks.im,  asedeno@MIT.EDU,
	 asedeno@google.com, avarab@gmail.com
Subject: Re: [PATCH v4 0/3] compat/posix.h: enable UNUSED warning messages for Clang
Date: Sat, 13 Jun 2026 09:39:03 -0700	[thread overview]
Message-ID: <xmqqse6qe6oo.fsf@gitster.g> (raw)
In-Reply-To: <20260613122711.38662-1-dominik.loidolt@univie.ac.at> (Dominik Loidolt's message of "Sat, 13 Jun 2026 14:27:08 +0200")

Dominik Loidolt <dominik.loidolt@univie.ac.at> writes:

> This series enables the intended UNUSED warning message with Clang by
> adding a dedicated Clang version check. It also cleans up the nearby
> GIT_GNUC_PREREQ() and UNUSED macros.
>
> Changes since v3:
> - split style-only cleanups into their own patch
> - fix the UNUSED preprocessor indentation style
> - simplify the GIT_GNUC_PREREQ() comparison commit message
> - keep the Clang-specific note in the patch that adds GIT_CLANG_PREREQ()
>
> Thanks,
>  Dominik
>
> Dominik Loidolt (3):
>   compat/posix.h: enable UNUSED warning messages for Clang
>   compat/posix.h: clean up GIT_GNUC_PREREQ() and UNUSED
>   compat/posix.h: simplify GIT_GNUC_PREREQ() comparison

Looking good and all the points Patrick raised during the review of
the previous round seem to have been addressed nicely.

Will replace.  Shall we mark it for 'next' now?

Thanks.

      parent reply	other threads:[~2026-06-13 16:39 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-03 15:12 [PATCH] compat/posix.h: enable UNUSED warning messages for Clang Dominik Loidolt
2026-05-04  1:10 ` Junio C Hamano
2026-05-04  1:41   ` Junio C Hamano
2026-06-05  8:44     ` Dominik Loidolt
2026-06-05  9:46 ` [PATCH v2] " Dominik Loidolt
2026-06-05 10:40   ` Patrick Steinhardt
2026-06-05 11:50     ` Dominik Loidolt
2026-06-05 13:22       ` Patrick Steinhardt
2026-06-05 15:53         ` Dominik Loidolt
2026-06-08  6:20           ` Patrick Steinhardt
2026-06-08 12:44   ` [PATCH v3 1/2] " Dominik Loidolt
2026-06-08 12:44     ` [PATCH v3 2/2] compat/posix.h: simplify GIT_GNUC_PREREQ() comparison Dominik Loidolt
2026-06-12 13:27       ` Patrick Steinhardt
2026-06-12 19:04         ` Dominik Loidolt
2026-06-13 12:27     ` [PATCH v4 0/3] compat/posix.h: enable UNUSED warning messages for Clang Dominik Loidolt
2026-06-13 12:27       ` [PATCH v4 1/3] " Dominik Loidolt
2026-06-13 12:27       ` [PATCH v4 2/3] compat/posix.h: clean up GIT_GNUC_PREREQ() and UNUSED Dominik Loidolt
2026-06-13 12:27       ` [PATCH v4 3/3] compat/posix.h: simplify GIT_GNUC_PREREQ() comparison Dominik Loidolt
2026-06-13 16:39       ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqse6qe6oo.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=asedeno@MIT.EDU \
    --cc=asedeno@google.com \
    --cc=avarab@gmail.com \
    --cc=dominik.loidolt@univie.ac.at \
    --cc=git@vger.kernel.org \
    --cc=ps@pks.im \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox