From: Junio C Hamano <gitster@pobox.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: git@vger.kernel.org, Karthik Nayak <karthik.188@gmail.com>,
Elijah Newren <newren@gmail.com>, Tian Yuchen <cat@malon.dev>
Subject: Re: [PATCH v3 00/18] setup: drop uses of `the_repository`
Date: Wed, 20 May 2026 12:31:55 +0900 [thread overview]
Message-ID: <xmqqse7m4uz8.fsf@gitster.g> (raw)
In-Reply-To: <20260519-pks-setup-wo-the-repository-v3-0-a00d8ea8b07f@pks.im> (Patrick Steinhardt's message of "Tue, 19 May 2026 11:52:04 +0200")
Patrick Steinhardt <ps@pks.im> writes:
> Changes in v3:
> - Reverse the order of the commits that refactor `is_inside_gitdir()`
> and `is_inside_work_tree()` and clarify the logic around why we do
> (or do not) have to use realpath(3p). The code is ultimately not
> changed though, we still resolve the realpath for both even though
> it's not strictly necessary to do so for the working tree.
> - Link to v2: https://patch.msgid.link/20260518-pks-setup-wo-the-repository-v2-0-6933c0f1d568@pks.im
Looking good. Let me mark the topic for 'next'.
Thanks.
prev parent reply other threads:[~2026-05-20 3:31 UTC|newest]
Thread overview: 73+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-20 8:22 [PATCH 00/18] setup: drop uses of `the_repository` Patrick Steinhardt
2026-04-20 8:22 ` [PATCH 01/18] setup: replace use of `the_repository` in static functions Patrick Steinhardt
2026-04-20 8:22 ` [PATCH 02/18] setup: stop using `the_repository` in `is_inside_worktree()` Patrick Steinhardt
2026-05-17 16:18 ` Tian Yuchen
2026-05-17 23:41 ` Junio C Hamano
2026-05-18 7:46 ` Patrick Steinhardt
2026-05-19 1:22 ` Junio C Hamano
2026-05-19 9:50 ` Patrick Steinhardt
2026-04-20 8:22 ` [PATCH 03/18] setup: stop using `the_repository` in `is_inside_git_dir()` Patrick Steinhardt
2026-04-20 8:22 ` [PATCH 04/18] setup: stop using `the_repository` in `prefix_path()` Patrick Steinhardt
2026-04-20 8:22 ` [PATCH 05/18] setup: stop using `the_repository` in `path_inside_repo()` Patrick Steinhardt
2026-04-20 8:22 ` [PATCH 06/18] setup: stop using `the_repository` in `verify_filename()` Patrick Steinhardt
2026-04-20 8:22 ` [PATCH 07/18] setup: stop using `the_repository` in `verify_non_filename()` Patrick Steinhardt
2026-04-20 8:22 ` [PATCH 08/18] setup: stop using `the_repository` in `enter_repo()` Patrick Steinhardt
2026-04-20 8:22 ` [PATCH 09/18] setup: stop using `the_repository` in `setup_work_tree()` Patrick Steinhardt
2026-04-20 8:22 ` [PATCH 10/18] setup: stop using `the_repository` in `set_git_work_tree()` Patrick Steinhardt
2026-04-20 8:22 ` [PATCH 11/18] setup: stop using `the_repository` in `setup_git_env()` Patrick Steinhardt
2026-04-20 8:22 ` [PATCH 12/18] setup: stop using `the_repository` in `setup_git_directory_gently()` Patrick Steinhardt
2026-04-20 8:22 ` [PATCH 13/18] setup: stop using `the_repository` in `setup_git_directory()` Patrick Steinhardt
2026-04-20 8:22 ` [PATCH 14/18] setup: stop using `the_repository` in `upgrade_repository_format()` Patrick Steinhardt
2026-04-20 8:22 ` [PATCH 15/18] setup: stop using `the_repository` in `check_repository_format()` Patrick Steinhardt
2026-04-20 8:22 ` [PATCH 16/18] setup: stop using `the_repository` in `initialize_repository_version()` Patrick Steinhardt
2026-04-20 8:22 ` [PATCH 17/18] setup: stop using `the_repository` in `create_reference_database()` Patrick Steinhardt
2026-04-20 8:22 ` [PATCH 18/18] setup: stop using `the_repository` in `init_db()` Patrick Steinhardt
2026-04-20 15:50 ` [PATCH 00/18] setup: drop uses of `the_repository` Elijah Newren
2026-04-21 9:41 ` Patrick Steinhardt
2026-04-20 17:11 ` Junio C Hamano
2026-04-21 9:41 ` Patrick Steinhardt
2026-05-18 9:30 ` [PATCH v2 " Patrick Steinhardt
2026-05-18 9:30 ` [PATCH v2 01/18] setup: replace use of `the_repository` in static functions Patrick Steinhardt
2026-05-19 8:03 ` Karthik Nayak
2026-05-18 9:30 ` [PATCH v2 02/18] setup: stop using `the_repository` in `is_inside_worktree()` Patrick Steinhardt
2026-05-19 8:23 ` Karthik Nayak
2026-05-19 9:47 ` Patrick Steinhardt
2026-05-18 9:30 ` [PATCH v2 03/18] setup: stop using `the_repository` in `is_inside_git_dir()` Patrick Steinhardt
2026-05-19 8:25 ` Karthik Nayak
2026-05-18 9:30 ` [PATCH v2 04/18] setup: stop using `the_repository` in `prefix_path()` Patrick Steinhardt
2026-05-18 9:30 ` [PATCH v2 05/18] setup: stop using `the_repository` in `path_inside_repo()` Patrick Steinhardt
2026-05-18 9:30 ` [PATCH v2 06/18] setup: stop using `the_repository` in `verify_filename()` Patrick Steinhardt
2026-05-18 9:30 ` [PATCH v2 07/18] setup: stop using `the_repository` in `verify_non_filename()` Patrick Steinhardt
2026-05-18 9:30 ` [PATCH v2 08/18] setup: stop using `the_repository` in `enter_repo()` Patrick Steinhardt
2026-05-18 9:31 ` [PATCH v2 09/18] setup: stop using `the_repository` in `setup_work_tree()` Patrick Steinhardt
2026-05-18 9:31 ` [PATCH v2 10/18] setup: stop using `the_repository` in `set_git_work_tree()` Patrick Steinhardt
2026-05-18 9:31 ` [PATCH v2 11/18] setup: stop using `the_repository` in `setup_git_env()` Patrick Steinhardt
2026-05-18 9:31 ` [PATCH v2 12/18] setup: stop using `the_repository` in `setup_git_directory_gently()` Patrick Steinhardt
2026-05-18 9:31 ` [PATCH v2 13/18] setup: stop using `the_repository` in `setup_git_directory()` Patrick Steinhardt
2026-05-18 9:31 ` [PATCH v2 14/18] setup: stop using `the_repository` in `upgrade_repository_format()` Patrick Steinhardt
2026-05-18 9:31 ` [PATCH v2 15/18] setup: stop using `the_repository` in `check_repository_format()` Patrick Steinhardt
2026-05-18 9:31 ` [PATCH v2 16/18] setup: stop using `the_repository` in `initialize_repository_version()` Patrick Steinhardt
2026-05-18 9:31 ` [PATCH v2 17/18] setup: stop using `the_repository` in `create_reference_database()` Patrick Steinhardt
2026-05-18 9:31 ` [PATCH v2 18/18] setup: stop using `the_repository` in `init_db()` Patrick Steinhardt
2026-05-19 9:26 ` [PATCH v2 00/18] setup: drop uses of `the_repository` Karthik Nayak
2026-05-19 9:51 ` Patrick Steinhardt
2026-05-19 9:52 ` [PATCH v3 " Patrick Steinhardt
2026-05-19 9:52 ` [PATCH v3 01/18] setup: replace use of `the_repository` in static functions Patrick Steinhardt
2026-05-19 9:52 ` [PATCH v3 02/18] setup: stop using `the_repository` in `is_inside_git_dir()` Patrick Steinhardt
2026-05-19 9:52 ` [PATCH v3 03/18] setup: stop using `the_repository` in `is_inside_work_tree()` Patrick Steinhardt
2026-05-19 9:52 ` [PATCH v3 04/18] setup: stop using `the_repository` in `prefix_path()` Patrick Steinhardt
2026-05-19 9:52 ` [PATCH v3 05/18] setup: stop using `the_repository` in `path_inside_repo()` Patrick Steinhardt
2026-05-19 9:52 ` [PATCH v3 06/18] setup: stop using `the_repository` in `verify_filename()` Patrick Steinhardt
2026-05-19 9:52 ` [PATCH v3 07/18] setup: stop using `the_repository` in `verify_non_filename()` Patrick Steinhardt
2026-05-19 9:52 ` [PATCH v3 08/18] setup: stop using `the_repository` in `enter_repo()` Patrick Steinhardt
2026-05-19 9:52 ` [PATCH v3 09/18] setup: stop using `the_repository` in `setup_work_tree()` Patrick Steinhardt
2026-05-19 9:52 ` [PATCH v3 10/18] setup: stop using `the_repository` in `set_git_work_tree()` Patrick Steinhardt
2026-05-19 9:52 ` [PATCH v3 11/18] setup: stop using `the_repository` in `setup_git_env()` Patrick Steinhardt
2026-05-19 9:52 ` [PATCH v3 12/18] setup: stop using `the_repository` in `setup_git_directory_gently()` Patrick Steinhardt
2026-05-19 9:52 ` [PATCH v3 13/18] setup: stop using `the_repository` in `setup_git_directory()` Patrick Steinhardt
2026-05-19 9:52 ` [PATCH v3 14/18] setup: stop using `the_repository` in `upgrade_repository_format()` Patrick Steinhardt
2026-05-19 9:52 ` [PATCH v3 15/18] setup: stop using `the_repository` in `check_repository_format()` Patrick Steinhardt
2026-05-19 9:52 ` [PATCH v3 16/18] setup: stop using `the_repository` in `initialize_repository_version()` Patrick Steinhardt
2026-05-19 9:52 ` [PATCH v3 17/18] setup: stop using `the_repository` in `create_reference_database()` Patrick Steinhardt
2026-05-19 9:52 ` [PATCH v3 18/18] setup: stop using `the_repository` in `init_db()` Patrick Steinhardt
2026-05-20 3:31 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqse7m4uz8.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=cat@malon.dev \
--cc=git@vger.kernel.org \
--cc=karthik.188@gmail.com \
--cc=newren@gmail.com \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox