From: Junio C Hamano <gitster@pobox.com>
To: "Li Chen" <me@linux.beauty>
Cc: "Kristoffer Haugsbakk" <kristofferhaugsbakk@fastmail.com>,
"Phillip Wood" <phillip.wood@dunelm.org.uk>,
git <git@vger.kernel.org>
Subject: Re: [PATCH v6 4/4] rebase: support --trailer
Date: Tue, 20 Jan 2026 12:49:31 -0800 [thread overview]
Message-ID: <xmqqsec0xb50.fsf@gitster.g> (raw)
In-Reply-To: <cb5a792f-c763-4fbf-bfcc-52f66c895c9e@app.fastmail.com> (Kristoffer Haugsbakk's message of "Mon, 24 Nov 2025 16:45:49 +0100")
"Kristoffer Haugsbakk" <kristofferhaugsbakk@fastmail.com> writes:
> On Wed, Nov 5, 2025, at 15:29, Li Chen wrote:
>> From: Li Chen <chenl311@chinatelecom.cn>
> ...
> Same problem as I commented on in https://lore.kernel.org/git/cbe93380-e145-4ebd-a213-928b8c3ba085@app.fastmail.com/
>
> The `See also INCOMPATIBLE OPTIONS below.` is not indented to the same
> level as `--signoff`, where it belongs.
>
>> +--trailer=<trailer>::
>> + Append the given trailer line(s) to every rebased commit
>> + message, processed via linkgit:git-interpret-trailers[1].
>> + When this option is present *rebase automatically implies*
>> + `--force-rebase` so that fast‑forwarded commits are also
>> + rewritten.
>> +
>>[snip]
After this and [*] the discussion stopped and the topic has been
dormant since then for full two months. I'd drop the topic from
'seen' soonish but that does not mean an improved version of this
patch is unwelcome.
Thanks.
[Reference]
* https://lore.kernel.org/git/19a8fe42354.3909481a3912041.7970296104893780556@linux.beauty/
next prev parent reply other threads:[~2026-01-20 20:49 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-05 14:29 [PATCH v6 0/4] rebase: support --trailer Li Chen
2025-11-05 14:29 ` [PATCH v6 1/4] interpret-trailers: factor out buffer-based processing to process_trailers() Li Chen
2025-11-05 16:57 ` Junio C Hamano
2025-11-10 16:27 ` Phillip Wood
2025-11-10 19:29 ` Li Chen
2025-11-10 22:08 ` Junio C Hamano
2025-11-10 19:22 ` Li Chen
2025-11-05 14:29 ` [PATCH v6 2/4] trailer: move process_trailers to trailer.h Li Chen
2025-11-05 17:38 ` Junio C Hamano
2025-11-05 14:29 ` [PATCH v6 3/4] trailer: append trailers in-process and drop the fork to `interpret-trailers` Li Chen
2025-11-05 17:56 ` Junio C Hamano
2025-11-10 19:27 ` Li Chen
2025-11-10 16:38 ` Phillip Wood
2025-11-10 19:14 ` Li Chen
2026-02-24 6:36 ` Li Chen
2025-11-11 16:55 ` Phillip Wood
2025-11-05 14:29 ` [PATCH v6 4/4] rebase: support --trailer Li Chen
2025-11-12 14:48 ` Phillip Wood
2025-11-24 15:45 ` Kristoffer Haugsbakk
2026-01-20 20:49 ` Junio C Hamano [this message]
2025-11-05 16:30 ` [PATCH v6 0/4] " Junio C Hamano
2025-11-10 19:17 ` Li Chen
2025-11-12 14:50 ` Phillip Wood
2025-11-17 3:38 ` Li Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqsec0xb50.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=kristofferhaugsbakk@fastmail.com \
--cc=me@linux.beauty \
--cc=phillip.wood@dunelm.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox