From: Junio C Hamano <gitster@pobox.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: Jiang Xin <worldhello.net@gmail.com>,
Git List <git@vger.kernel.org>,
Jiang Xin <zhiyou.jx@alibaba-inc.com>
Subject: Re: [PATCH] help: report on whether or not gettext is enabled
Date: Mon, 19 Jan 2026 16:15:14 -0800 [thread overview]
Message-ID: <xmqqsec13zsd.fsf@gitster.g> (raw)
In-Reply-To: <aW3XUxaomqGbtpEj@pks.im> (Patrick Steinhardt's message of "Mon, 19 Jan 2026 08:03:47 +0100")
Patrick Steinhardt <ps@pks.im> writes:
>> Combined with the vintage of Git binary that had these help text,
>> the fact that an "enabled" line is missing is enough clue to
>> diagnose.
>> ...
>
> One reason why I personally prefer to have enabled/disabled is that it
> allows you to discern the following two cases:
>
> - You have a modern version of Git that doesn't have gettext.
>
> - You have an old version of Git that doesn't know to print
> information about whether or not gettext is enabled.
When you see no "gettext:" line in the report, you can tell between
the above two cases by looking at what the first entry in the same
report "git version --build-options" produced, which is the Git
version, can't you?
next prev parent reply other threads:[~2026-01-20 0:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-16 2:29 [PATCH] help: report on whether or not gettext is enabled Jiang Xin
2026-01-16 15:46 ` Junio C Hamano
2026-01-17 13:59 ` [PATCH v2] " Jiang Xin
2026-01-19 7:03 ` [PATCH] " Patrick Steinhardt
2026-01-19 10:17 ` Jiang Xin
2026-01-20 0:15 ` Junio C Hamano [this message]
2026-01-20 5:47 ` Patrick Steinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqsec13zsd.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=ps@pks.im \
--cc=worldhello.net@gmail.com \
--cc=zhiyou.jx@alibaba-inc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox