From: Junio C Hamano <gitster@pobox.com>
To: "Matthieu Beauchamp-Boulay via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Matheus Tavares <matheus.tavb@gmail.com>,
Johannes Schindelin <johannes.schindelin@gmx.de>,
Matthieu Beauchamp-Boulay <matthieu.beauchamp.boulay@gmail.com>
Subject: Re: [PATCH] ignores: handle non UTF-8 exclude files
Date: Sun, 04 Jan 2026 11:54:46 +0900 [thread overview]
Message-ID: <xmqqsecmnl3d.fsf@gitster.g> (raw)
In-Reply-To: <pull.2157.git.git.1767478617198.gitgitgadget@gmail.com> (Matthieu Beauchamp-Boulay via GitGitGadget's message of "Sat, 03 Jan 2026 22:16:57 +0000")
"Matthieu Beauchamp-Boulay via GitGitGadget"
<gitgitgadget@gmail.com> writes:
> From: Matthieu Beauchamp-Boulay <matthieu.beauchamp.boulay@gmail.com>
>
> When reading exclude files, git assumes it is encoded in UTF-8 and will
> fail to apply patterns if it isn't.
Is it true? I thought we assume that the exclude patters are
written in such a way to match the encoding of the pathnames,
whatever used on the platform that our calls to readdir(3) returns.
Some platforms may have compat/ code to convert these paths and
force use of UTF-8, but please do not write such platform local
conventions as if it were universal characteristics of our system.
"ignores" -> "exclude" on the title, as that is the canonical word
we use in the codebase to refer to the ignore mechanism.
next prev parent reply other threads:[~2026-01-04 2:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-03 22:16 [PATCH] ignores: handle non UTF-8 exclude files Matthieu Beauchamp-Boulay via GitGitGadget
2026-01-04 2:54 ` Junio C Hamano [this message]
2026-01-06 19:52 ` Matthieu Beauchamp
2026-01-04 17:35 ` Torsten Bögershausen
2026-01-06 20:32 ` Matthieu Beauchamp
2026-01-07 14:36 ` Phillip Wood
2026-01-04 19:40 ` brian m. carlson
2026-01-06 20:45 ` Matthieu Beauchamp
2026-01-06 23:22 ` brian m. carlson
2026-01-07 1:35 ` Collin Funk
2026-01-07 14:28 ` Phillip Wood
2026-01-07 23:38 ` brian m. carlson
2026-01-08 1:13 ` Collin Funk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqsecmnl3d.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=johannes.schindelin@gmx.de \
--cc=matheus.tavb@gmail.com \
--cc=matthieu.beauchamp.boulay@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).