git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Would it make sense to add a commit.signOff config?
@ 2025-12-14 16:10 Stefan Haller
  2025-12-14 16:44 ` Carlo Marcelo Arenas Belón
  0 siblings, 1 reply; 20+ messages in thread
From: Stefan Haller @ 2025-12-14 16:10 UTC (permalink / raw)
  To: Git

I find it interesting that of all the git commands that take a --signoff
argument, format-patch is the only one that has a corresponding config
to turn it on for all invocations. I would have thought that git commit
needs this even more; I find it reasonable for users to decide that they
want to add a Signed-off-by trailer to all the commits they make.

But then, what about merge, cherry-pick, and revert? Does it make sense
to turn it on globally for those as well?

The background of this question is lazygit, which has a config for
enabling --signoff for all commits made by it. We recently had a feature
request to extend the meaning of that config to revert as well, and the
discussion came up whether that's a good idea, and if so, whether it
should also extend to cherry-pick and merge.

Any opinions about this? Since I work mostly in closed-source contexts I
don't have much experience with the meaning of Signed-off-by trailers.

-Stefan

^ permalink raw reply	[flat|nested] 20+ messages in thread

end of thread, other threads:[~2025-12-19 12:52 UTC | newest]

Thread overview: 20+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-12-14 16:10 Would it make sense to add a commit.signOff config? Stefan Haller
2025-12-14 16:44 ` Carlo Marcelo Arenas Belón
2025-12-14 23:44   ` Junio C Hamano
2025-12-14 23:52     ` Collin Funk
2025-12-15  1:22     ` brian m. carlson
2025-12-15  1:59       ` Junio C Hamano
2025-12-15 22:29         ` brian m. carlson
2025-12-16  1:20           ` Junio C Hamano
2025-12-16  0:17         ` Elijah Newren
2025-12-16  2:29           ` Junio C Hamano
2025-12-16  7:10             ` Johannes Sixt
2025-12-16  7:15           ` Johannes Sixt
2025-12-16 18:54         ` [PATCH v2] commit: document that $command.signoff will not be added Junio C Hamano
2025-12-16 19:48           ` Elijah Newren
2025-12-17  4:47             ` Junio C Hamano
2025-12-17  7:40               ` Elijah Newren
2025-12-17 13:51           ` Johannes Sixt
2025-12-17 23:16             ` Junio C Hamano
2025-12-19  7:33           ` Kristoffer Haugsbakk
2025-12-19 12:52             ` Junio C Hamano

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).