From: Junio C Hamano <gitster@pobox.com>
To: git@vger.kernel.org
Cc: Andrew Kreimer <algonell@gmail.com>,
Taylor Blau <me@ttaylorr.com>, Todd Zullinger <tmz@pobox.com>
Subject: [PATCH] t1016: make sure to use specified GPG
Date: Fri, 10 Oct 2025 14:14:00 -0700 [thread overview]
Message-ID: <xmqqsefq7947.fsf@gitster.g> (raw)
c348192a (t1016: clean up style, 2024-10-22) fixed a coding style
violation that has an extra space between redirection operator ">"
and the redirection target, but at the same time, replaced the use
of "git config" to set a configuration variable to be used by the
remainder of tests with "test_config". The pattern employed here is
that the first set-up test prepares the environment to be used by
subsequent tests, which then use the settings left by this set-up
test to perform their tasks. Using test_config in the first set-up
test means the config setting made by the set-up test is reverted at
the end of the first set-up test, which totally misses the point.
Go back to use "git config" to fix this.
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
* The commit in question was from October last year, and I didn't
notice it until I looked at how the test script evolved. It is a
bit embarrassing that we didn't catch it during review.
t/t1016-compatObjectFormat.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/t1016-compatObjectFormat.sh b/t/t1016-compatObjectFormat.sh
index 8341a2fe83..cb6d308f1d 100755
--- a/t/t1016-compatObjectFormat.sh
+++ b/t/t1016-compatObjectFormat.sh
@@ -116,7 +116,7 @@ do
git config core.repositoryformatversion 1 &&
git config extensions.objectformat $hash &&
git config extensions.compatobjectformat $(compat_hash $hash) &&
- test_config gpg.program $TEST_DIRECTORY/t1016/gpg &&
+ git config gpg.program $TEST_DIRECTORY/t1016/gpg &&
echo "Hello World!" >hello &&
eval hello_${hash}_oid=$(git hash-object hello) &&
git update-index --add hello &&
--
2.51.0-616-gc7d8d4fd8b
next reply other threads:[~2025-10-10 21:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-10 21:14 Junio C Hamano [this message]
2025-10-12 14:23 ` [PATCH] t1016: make sure to use specified GPG Todd Zullinger
2025-10-12 15:11 ` Junio C Hamano
2025-10-12 18:31 ` Todd Zullinger
2025-10-23 20:52 ` Junio C Hamano
2025-10-24 1:52 ` Todd Zullinger
2025-10-12 20:40 ` Andrew Kreimer
2025-10-13 15:38 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqsefq7947.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=algonell@gmail.com \
--cc=git@vger.kernel.org \
--cc=me@ttaylorr.com \
--cc=tmz@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).