git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Tao Klerks <tao@klerks.biz>
Cc: Patrick Steinhardt <ps@pks.im>,
	 Tao Klerks via GitGitGadget <gitgitgadget@gmail.com>,
	 git@vger.kernel.org
Subject: Re: [PATCH] replace-refs: fix support of qualified replace ref paths
Date: Tue, 29 Apr 2025 17:11:25 -0700	[thread overview]
Message-ID: <xmqqselq33v6.fsf@gitster.g> (raw)
In-Reply-To: <CAPMMpohgEXVPHKCQtvc-zLC35qtY+qJ9WgQO_quOgUG01eyTOw@mail.gmail.com> (Tao Klerks's message of "Tue, 29 Apr 2025 21:35:52 +0200")

Tao Klerks <tao@klerks.biz> writes:

> This is already accounted for with a hard error: If you end up with
> duplicate replace ref targets, many operations fail with a clear
> error. Clean up your replace refs and you're off to the races again.

OK.  As long as that safety is there, I offhand see no more reason
to forbid it.  As you said, it can lead to a useful use case.

      reply	other threads:[~2025-04-30  0:11 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-26  7:10 [PATCH] replace-refs: fix support of qualified replace ref paths Tao Klerks via GitGitGadget
2025-04-29 10:46 ` Patrick Steinhardt
2025-04-29 18:46   ` Junio C Hamano
2025-04-29 19:35     ` Tao Klerks
2025-04-30  0:11       ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqselq33v6.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=ps@pks.im \
    --cc=tao@klerks.biz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).