From: Junio C Hamano <gitster@pobox.com>
To: Mahendra Dani <danimahendra0904@gmail.com>
Cc: Patrick Steinhardt <ps@pks.im>, git@vger.kernel.org
Subject: Re: [PATCH 1/1] t1403: prefer test_path_exists helper function
Date: Tue, 04 Mar 2025 09:44:10 -0800 [thread overview]
Message-ID: <xmqqsensr8r9.fsf@gitster.g> (raw)
In-Reply-To: <CABGrwBBaHzM9tE6vWkuMSZuUbHVWwCZVTgkvMb04C=NYyGCLAw@mail.gmail.com> (Mahendra Dani's message of "Tue, 4 Mar 2025 23:05:29 +0530")
Mahendra Dani <danimahendra0904@gmail.com> writes:
> Yes, due to the use of the "-f" flag, it's not necessary to explicitly
> check the lack of file using `test -e`.
> But if we drop the "-f" flag, we will have to check the lack of file
> using `test -e` or
> `test_path_is_file()`.
Isn't it the other way around?
$ rm -f nosuch ; echo $?
0
$ rm nosuch ; echo $?
rm: cannot remove 'nosuch': No such file or directory
1
next prev parent reply other threads:[~2025-03-04 17:44 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-01 10:58 [GSOC][PATCH 0/1] t1403: prefer test_path_exists helper function Mahendra Dani
2025-03-01 10:58 ` [PATCH 1/1] " Mahendra Dani
2025-03-03 10:26 ` Patrick Steinhardt
2025-03-04 2:27 ` Mahendra Dani
2025-03-04 12:05 ` Junio C Hamano
2025-03-04 17:24 ` Mahendra Dani
2025-03-04 17:26 ` Junio C Hamano
2025-03-04 17:35 ` Mahendra Dani
2025-03-04 17:44 ` Junio C Hamano [this message]
2025-03-04 17:49 ` Mahendra Dani
2025-03-04 18:07 ` Junio C Hamano
2025-03-04 17:35 ` Eric Sunshine
2025-03-04 17:49 ` Junio C Hamano
2025-03-04 18:07 ` Eric Sunshine
2025-03-04 18:28 ` Eric Sunshine
2025-03-04 18:30 ` Junio C Hamano
2025-03-04 9:15 ` [GSOC][PATCH v2 0/1] t1403: verify path exists and is a file Mahendra Dani
2025-03-04 9:41 ` [GSOC][PATCH v3 " Mahendra Dani
2025-03-04 9:41 ` [PATCH v3 1/1] t1403: verify that " Mahendra Dani
2025-03-04 18:05 ` Junio C Hamano
2025-03-04 18:06 ` Junio C Hamano
2025-03-04 18:13 ` Mahendra Dani
2025-03-04 11:23 ` [PATCH v4 0/1] t1403: verify " Mahendra Dani
2025-03-04 11:27 ` Mahendra Dani
2025-03-04 11:27 ` [PATCH v4 1/1] t1403: verify that " Mahendra Dani
2025-03-04 18:13 ` Junio C Hamano
2025-03-04 18:19 ` Mahendra Dani
2025-03-04 16:00 ` [GSOC][PATCH v3 0/1] t1403: verify " Junio C Hamano
2025-03-04 9:27 ` [PATCH v2 1/1] t1403: verify that " Mahendra Dani
2025-03-04 11:02 ` Patrick Steinhardt
2025-03-04 11:15 ` Mahendra Dani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqsensr8r9.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=danimahendra0904@gmail.com \
--cc=git@vger.kernel.org \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).