git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: git@vger.kernel.org,  Justin Tobler <jltobler@gmail.com>,
	 Johannes Sixt <j6t@kdbg.org>
Subject: Re: What's cooking in git.git (Feb 2025, #01; Tue, 4)
Date: Wed, 05 Feb 2025 16:04:47 -0800	[thread overview]
Message-ID: <xmqqseoskkf4.fsf@gitster.g> (raw)
In-Reply-To: <xmqq7c64nn4o.fsf@gitster.g> (Junio C. Hamano's message of "Wed, 05 Feb 2025 12:37:59 -0800")

Junio C Hamano <gitster@pobox.com> writes:

> Patrick Steinhardt <ps@pks.im> writes:
>
>> One topic that I miss in the cover letter is [1]. You probably forgot to
>> pick it up :)
>>
>> [1]: <20250125-b4-pks-reftable-win32-in-use-errors-v1-1-356dbc783b4f@pks.im>
>
> OK, I was wondering if we are going to rethink after seeing some
> comments but with blessing by j6t [*], I guess this is fine.
>
> [*]: <37c14379-68e4-4c52-a08d-b78c7797ef26@kdbg.org>

Wait.  This works by futzing with unlink() call that is imported via
<git-compat-util.h> which you got rid of in a separate topic, and
given the overall theme of sans-compat-util topic, I do not think
you want to include <compat/mingw.h> either directly or indirectly
(via <git-compat-util.h> as we used to), either.

So where would that leave us...?

  reply	other threads:[~2025-02-06  0:04 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-05  2:08 What's cooking in git.git (Feb 2025, #01; Tue, 4) Junio C Hamano
2025-02-05  7:03 ` Patrick Steinhardt
2025-02-05 20:37   ` Junio C Hamano
2025-02-06  0:04     ` Junio C Hamano [this message]
2025-02-06  6:47       ` Patrick Steinhardt
2025-02-07 10:11 ` Toon Claes
2025-02-07 17:11   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqseoskkf4.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=j6t@kdbg.org \
    --cc=jltobler@gmail.com \
    --cc=ps@pks.im \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).