git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Illia Bobyr <illia.bobyr@gmail.com>
Cc: Jeff King <peff@peff.net>,  git@vger.kernel.org
Subject: Re: Long names for `git log -S` and `git log -G`
Date: Fri, 22 Nov 2024 19:51:21 +0900	[thread overview]
Message-ID: <xmqqserjsfrq.fsf@gitster.g> (raw)
In-Reply-To: <470fe577-b26d-4393-8fa6-8f73ca4302de@gmail.com> (Illia Bobyr's message of "Thu, 21 Nov 2024 15:31:00 -0800")

Illia Bobyr <illia.bobyr@gmail.com> writes:

> On 11/18/24 19:52, Junio C Hamano wrote:
>>> `--pickaxe-grep` for `-G` seems like a reasonable alternative name for `-G`.
>> That is probably OK (even though "-G" is not exactly what the
>> pickaxe machinery wants to do; "--grep-in-patch" might be closer to
>> the intent).
> Imagining, that I am starting from scratch for this functionality, I think I
> would also consider "patch".  Though, as we have 4 related argument names, I
> wonder if using it as a prefix would create a more consistent UX.
>
> Something like:
>
> "--patch-grep" for "-G"
> "--patch-modifies" for "-S"

Ahh, "modifies" is a great verb.  It sounds quite logical, but "-S"
does not have to genereate a patch internally for it to work, so
"--patch-modifies" is a bit of white lie.

> "--patch-search-show-all"/"--patch-show-all" for "--pickaxe-all"
> "--patch-search-regex"/"--patch-regex" for "--pickaxe-regex"

These already have their own established long names, so it is
outside the scope of this topic, and I doubt it is worth giving
these additional aliases (as you seem to agree).

  reply	other threads:[~2024-11-22 10:51 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-18 23:56 Long names for `git log -S` and `git log -G` Illia Bobyr
2024-11-19  3:52 ` Junio C Hamano
2024-11-19 18:58   ` Jeff King
2024-11-21 23:31     ` Illia Bobyr
2024-11-22 10:51       ` Junio C Hamano [this message]
2025-02-05  2:24         ` [PATCH v2 0/1] " Illia Bobyr
2025-02-05  2:24         ` [PATCH v2 1/1] diff: --patch{-modifies,grep} arg names for -S and -G Illia Bobyr
2025-02-05  7:15           ` Johannes Sixt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqserjsfrq.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=illia.bobyr@gmail.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).