Re: [PATCH 5/4] ci: add Ubuntu 16.04 job to GitLab CI

[Junio C Hamano <gitster@pobox.com>]

Jeff King <peff@peff.net> writes:

> On Fri, Sep 13, 2024 at 07:52:51AM +0200, Patrick Steinhardt wrote:
>
>> In the preceding commits we had to convert the linux32 job to be based
>> on Ubuntu 20.04 instead of Ubuntu 16.04 due to a limitation in GitHub
>> Workflows. This was the only job left that still tested against this old
>> but supported Ubuntu version, and we have no other jobs that test with a
>> comparatively old Linux distribution.
>> 
>> Add a new job to GitLab CI that tests with Ubuntu 16.04 to cover the
>> resulting test gap. GitLab doesn't modify Docker images in the same way
>> GitHub does and thus doesn't fall prey to the same issue. There are two
>> compatibility issues uncovered by this:
>> 
>>   - Ubuntu 16.04 does not support HTTP/2 in Apache. We thus cannot set
>>     `GIT_TEST_HTTPD=true`, which would otherwise cause us to fail when
>>     Apache fails to start.
>> 
>>   - Ubuntu 16.04 cannot use recent JGit versions as they depend on a
>>     more recent Java runtime than we have available. We thus disable
>>     installing any kind of optional dependencies that do not come from
>>     the package manager.
>
> OK, this looks reasonable to me. I do think we could have our cake and
> eat it too on the Apache support if we added a GIT_TEST_HTTP2 knob. But
> it's probably not all that big a deal in practice, and after another 1.5
> years I think we'd drop this 16.04 job anyway (since it will be out of
> LTS then).
>
> Thanks for putting this together.

Yes, thanks, both.  Queued.