From: Junio C Hamano <gitster@pobox.com>
To: Phillip Wood <phillip.wood123@gmail.com>
Cc: "René Scharfe" <l.s.r@web.de>, "Git List" <git@vger.kernel.org>,
"Jorge Luis Martinez Gomez" <jol@jol.dev>,
"David Hull" <david.hull@friendbuy.com>
Subject: Re: [PATCH 1/2] diff: report copies and renames as changes in run_diff_cmd()
Date: Mon, 09 Sep 2024 09:59:05 -0700 [thread overview]
Message-ID: <xmqqseu8sqzq.fsf@gitster.g> (raw)
In-Reply-To: <b4ce7873-3dfa-443c-847c-64200fd065cc@gmail.com> (Phillip Wood's message of "Mon, 9 Sep 2024 16:16:06 +0100")
Phillip Wood <phillip.wood123@gmail.com> writes:
>> which is inconsistent with the quicker one. Fix it. Even if we ignore
>> the file contents (because it's empty or contains only ignored lines),
>> there's still the meta data change of adding or changing a filename, so
>> we need to report it in the exit code.
>> d7b97b7185 (diff: let external diffs report that changes are
>> uninteresting, 2024-06-09) set diff_from_contents if external diff
>> programs are allowed. This is the default e.g. for git diff, and so
>> that change exposed the inconsistency much more widely.
>
> Thanks for fixing this - both patches looks good to me.
Yup, thanks, both.
prev parent reply other threads:[~2024-09-09 16:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-08 7:05 [PATCH 1/2] diff: report copies and renames as changes in run_diff_cmd() René Scharfe
2024-09-08 7:08 ` [PATCH 2/2] diff: report dirty submodules as changes in builtin_diff() René Scharfe
2024-09-09 15:16 ` [PATCH 1/2] diff: report copies and renames as changes in run_diff_cmd() Phillip Wood
2024-09-09 16:59 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqseu8sqzq.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=david.hull@friendbuy.com \
--cc=git@vger.kernel.org \
--cc=jol@jol.dev \
--cc=l.s.r@web.de \
--cc=phillip.wood123@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).