From: Junio C Hamano <gitster@pobox.com>
To: Abhijeet Sonar <abhijeet.nkt@gmail.com>
Cc: Karthik Nayak <karthik.188@gmail.com>,
git@vger.kernel.org, Paul Millar <paul.millar@desy.de>,
Phillip Wood <phillip.wood123@gmail.com>,
Elijah Newren <newren@gmail.com>, Jeff King <peff@peff.net>
Subject: Re: Re* [PATCH v5] describe: refresh the index when 'broken' flag is used
Date: Wed, 26 Jun 2024 10:35:46 -0700 [thread overview]
Message-ID: <xmqqsewz1ua5.fsf@gitster.g> (raw)
In-Reply-To: <bbc223a3-2c82-4108-adf1-5e8518ff776e@gmail.com> (Abhijeet Sonar's message of "Wed, 26 Jun 2024 22:59:22 +0530")
Abhijeet Sonar <abhijeet.nkt@gmail.com> writes:
> To me, this looks much better. child_process_clear's name already
> suggests that is sort of like a destructor, so it makes sense to
> re-initialize everything here. I even wonder why it was not that way to
> begin with. I suppose no callers are assuming that it only clears args
> and env though?
I guess that validating that supposition is a prerequisite to
declare the change as "much better" and "makes sense".
next prev parent reply other threads:[~2024-06-26 17:35 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-25 13:35 [PATCH v3] describe: refresh the index when 'broken' flag is used Abhijeet Sonar
2024-06-25 15:59 ` Junio C Hamano
2024-06-25 16:05 ` Junio C Hamano
2024-06-26 11:16 ` Karthik Nayak
2024-06-26 6:11 ` Abhijeet Sonar
2024-06-26 6:37 ` [PATCH v4] " Abhijeet Sonar
2024-06-26 6:50 ` Abhijeet Sonar
2024-06-26 6:52 ` [PATCH v5] " Abhijeet Sonar
2024-06-26 11:30 ` Karthik Nayak
2024-06-26 12:06 ` Abhijeet Sonar
2024-06-26 15:34 ` Re* " Junio C Hamano
2024-06-26 16:17 ` Junio C Hamano
2024-06-26 17:29 ` Abhijeet Sonar
2024-06-26 17:35 ` Junio C Hamano [this message]
2024-06-26 17:45 ` Junio C Hamano
2024-06-26 18:07 ` Abhijeet Sonar
2024-06-26 18:49 ` Junio C Hamano
2024-06-26 20:34 ` Jeff King
2024-06-27 0:33 ` Jeff King
2024-06-26 21:23 ` Karthik Nayak
2024-06-26 14:59 ` Junio C Hamano
2024-06-26 18:31 ` Junio C Hamano
2024-06-26 19:08 ` [PATCH v7] " Abhijeet Sonar
2024-06-26 19:25 ` Abhijeet Sonar
2024-06-27 6:01 ` Abhijeet Sonar
2024-06-27 15:47 ` Junio C Hamano
2024-06-27 17:33 ` Abhijeet Sonar
2024-06-30 16:12 ` Karthik Nayak
2024-07-01 19:06 ` Junio C Hamano
2024-07-02 10:13 ` Karthik Nayak
2024-07-03 18:17 ` Junio C Hamano
2024-07-03 20:41 ` Karthik Nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqsewz1ua5.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=abhijeet.nkt@gmail.com \
--cc=git@vger.kernel.org \
--cc=karthik.188@gmail.com \
--cc=newren@gmail.com \
--cc=paul.millar@desy.de \
--cc=peff@peff.net \
--cc=phillip.wood123@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).