From: Junio C Hamano <gitster@pobox.com>
To: Marcel Telka <marcel@telka.sk>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v2] t/t0211-trace2-perf.sh: fix typo patern -> pattern
Date: Thu, 16 May 2024 09:34:21 -0700 [thread overview]
Message-ID: <xmqqseyhra0i.fsf@gitster.g> (raw)
In-Reply-To: <ZkW5ggOVlglfi64u@telcontar> (Marcel Telka's message of "Thu, 16 May 2024 09:45:06 +0200")
Marcel Telka <marcel@telka.sk> writes:
> The bug went unnoticed because grep with null RE matches everything.
>
> Signed-off-by: Marcel Telka <marcel@telka.sk>
> ---
> t/t0211-trace2-perf.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Thanks. Will queue.
> diff --git a/t/t0211-trace2-perf.sh b/t/t0211-trace2-perf.sh
> index 13ef69b92f..070fe7a5da 100755
> --- a/t/t0211-trace2-perf.sh
> +++ b/t/t0211-trace2-perf.sh
> @@ -233,7 +233,7 @@ have_counter_event () {
>
> pattern="d0|${thread}|${event}||||${category}|name:${name} value:${value}" &&
>
> - grep "${patern}" ${file}
> + grep "${pattern}" ${file}
> }
>
> test_expect_success 'global counter test/test1' '
prev parent reply other threads:[~2024-05-16 16:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-16 7:45 [PATCH v2] t/t0211-trace2-perf.sh: fix typo patern -> pattern Marcel Telka
2024-05-16 16:34 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqseyhra0i.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=marcel@telka.sk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).