* [PATCH v2] t/t0211-trace2-perf.sh: fix typo patern -> pattern
@ 2024-05-16 7:45 Marcel Telka
2024-05-16 16:34 ` Junio C Hamano
0 siblings, 1 reply; 2+ messages in thread
From: Marcel Telka @ 2024-05-16 7:45 UTC (permalink / raw)
To: git
The bug went unnoticed because grep with null RE matches everything.
Signed-off-by: Marcel Telka <marcel@telka.sk>
---
t/t0211-trace2-perf.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/t0211-trace2-perf.sh b/t/t0211-trace2-perf.sh
index 13ef69b92f..070fe7a5da 100755
--- a/t/t0211-trace2-perf.sh
+++ b/t/t0211-trace2-perf.sh
@@ -233,7 +233,7 @@ have_counter_event () {
pattern="d0|${thread}|${event}||||${category}|name:${name} value:${value}" &&
- grep "${patern}" ${file}
+ grep "${pattern}" ${file}
}
test_expect_success 'global counter test/test1' '
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] t/t0211-trace2-perf.sh: fix typo patern -> pattern
2024-05-16 7:45 [PATCH v2] t/t0211-trace2-perf.sh: fix typo patern -> pattern Marcel Telka
@ 2024-05-16 16:34 ` Junio C Hamano
0 siblings, 0 replies; 2+ messages in thread
From: Junio C Hamano @ 2024-05-16 16:34 UTC (permalink / raw)
To: Marcel Telka; +Cc: git
Marcel Telka <marcel@telka.sk> writes:
> The bug went unnoticed because grep with null RE matches everything.
>
> Signed-off-by: Marcel Telka <marcel@telka.sk>
> ---
> t/t0211-trace2-perf.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Thanks. Will queue.
> diff --git a/t/t0211-trace2-perf.sh b/t/t0211-trace2-perf.sh
> index 13ef69b92f..070fe7a5da 100755
> --- a/t/t0211-trace2-perf.sh
> +++ b/t/t0211-trace2-perf.sh
> @@ -233,7 +233,7 @@ have_counter_event () {
>
> pattern="d0|${thread}|${event}||||${category}|name:${name} value:${value}" &&
>
> - grep "${patern}" ${file}
> + grep "${pattern}" ${file}
> }
>
> test_expect_success 'global counter test/test1' '
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-05-16 16:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-16 7:45 [PATCH v2] t/t0211-trace2-perf.sh: fix typo patern -> pattern Marcel Telka
2024-05-16 16:34 ` Junio C Hamano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).