From: Junio C Hamano <gitster@pobox.com>
To: "John Cai via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, John Cai <johncai86@gmail.com>
Subject: Re: [PATCH] reftable: honor core.fsync
Date: Tue, 23 Jan 2024 13:50:04 -0800 [thread overview]
Message-ID: <xmqqsf2nlnxv.fsf@gitster.g> (raw)
In-Reply-To: <xmqq34unn8x4.fsf@gitster.g> (Junio C. Hamano's message of "Tue, 23 Jan 2024 11:31:35 -0800")
Junio C Hamano <gitster@pobox.com> writes:
> A comment and a half.
>
> * Can't the new "how to flush" go to the write-option structure?
> If you represent "no flush" as a NULL pointer in the flush member,
> most of the changes to the _test files can go, no?
Nah, that was a stupid comment. These are used to populate the
members of the reftable_writer instance being created, and it does
make sense to have flush_func immediately next to writer_func.
The part about using NULL as the value to say "do not use any flusher"
still stands, though. You do not have to expose noop_flush into the
global namespace that way.
Thanks.
next prev parent reply other threads:[~2024-01-23 21:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-23 18:51 [PATCH] reftable: honor core.fsync John Cai via GitGitGadget
2024-01-23 19:31 ` Junio C Hamano
2024-01-23 21:42 ` John Cai
2024-01-23 21:50 ` Junio C Hamano [this message]
2024-01-24 8:41 ` Patrick Steinhardt
2024-01-24 17:22 ` Junio C Hamano
2024-01-23 21:06 ` Kristoffer Haugsbakk
2024-01-23 21:38 ` John Cai
2024-01-29 9:48 ` Patrick Steinhardt
2024-01-29 17:15 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqsf2nlnxv.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=johncai86@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).