From: Junio C Hamano <gitster@pobox.com>
To: demerphq <demerphq@gmail.com>
Cc: "D. Ben Knoble" <ben.knoble@gmail.com>, Git <git@vger.kernel.org>
Subject: Re: grep: fix multibyte regex handling under macOS (1819ad327b7a1f19540a819813b70a0e8a7f798f)
Date: Wed, 01 Feb 2023 10:54:43 -0800 [thread overview]
Message-ID: <xmqqsffpz05o.fsf@gitster.g> (raw)
In-Reply-To: <CANgJU+WZR56xG+KL3P053aD_qTh+rBhZ01mqNajg2qRt_+RNMA@mail.gmail.com> (demerphq@gmail.com's message of "Wed, 1 Feb 2023 19:23:28 +0100")
demerphq <demerphq@gmail.com> writes:
> ... I saw some discussion
> recently that the mac regex engine doesn't play nicely in certain
> ways, but i dont recollect the details.
There was a discussion on BRE having and not having GNU-like
extension on macOS, in this thread
https://lore.kernel.org/git/26a0d4ca-3d97-ace4-1a1f-92b1ee6715a6@web.de/
The patch we ended up using avoids touching the behaviour with ERE,
as REG_ENHANCED on macOS affects REG_EXTENDED, but the issue we were
looking at in the thread was about BRE.
next prev parent reply other threads:[~2023-02-01 18:54 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-01 15:18 grep: fix multibyte regex handling under macOS (1819ad327b7a1f19540a819813b70a0e8a7f798f) D. Ben Knoble
2023-02-01 16:09 ` demerphq
2023-02-01 16:21 ` D. Ben Knoble
2023-02-01 18:23 ` demerphq
2023-02-01 18:54 ` Junio C Hamano [this message]
2023-02-01 21:33 ` D. Ben Knoble
2023-02-01 21:34 ` D. Ben Knoble
2023-02-01 22:15 ` Junio C Hamano
2023-02-01 23:03 ` Jeff King
2023-02-02 16:22 ` demerphq
2023-02-02 20:49 ` D. Ben Knoble
2023-02-03 17:01 ` Jeff King
2023-02-03 21:56 ` Ævar Arnfjörð Bjarmason
2023-02-04 11:17 ` Jeff King
2023-02-04 11:32 ` demerphq
2023-02-05 19:51 ` D. Ben Knoble
2023-02-07 18:23 ` Jeff King
2023-02-07 22:27 ` D. Ben Knoble
2023-02-07 18:19 ` Jeff King
2023-02-02 20:47 ` D. Ben Knoble
2023-02-03 16:55 ` Jeff King
2023-02-03 17:06 ` D. Ben Knoble
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqsffpz05o.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=ben.knoble@gmail.com \
--cc=demerphq@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox