git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
Cc: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>, git@vger.kernel.org
Subject: Re: On-branch topic description support?
Date: Thu, 21 Jul 2022 13:48:33 -0700	[thread overview]
Message-ID: <xmqqsfmufazi.fsf@gitster.g> (raw)
In-Reply-To: <20220721201918.xvunkyehxnjbwhjv@meerkat.local> (Konstantin Ryabitsev's message of "Thu, 21 Jul 2022 16:19:18 -0400")

Konstantin Ryabitsev <konstantin@linuxfoundation.org> writes:

> One thought that comes to mind -- perhaps it would be easier not to track the
> special commit, but designate the branch as a special "proposed changes"
> branch that could even "hide" the cover-letter merge commit (CLM) from most
> operations. It's still a simple two-parent merge commit, so it can be
> pushed/pulled with any existing remotes without requiring any changes on the
> server side, but operations like adding a regular new commit to the tip of
> the "proposed changes" branch would automatically move the merge commit so
> it's back at the tip. This way "not sure what you're trying to do" situations
> like this would be avoided:
>
>   A--B--C--CLM--D--E
>  /          /
> Y-----------

Sorry, you lost me.  It is quite clear what the user is trying to do
in this case.  After preparing the initial cut of the topic that has
three commits, A, B, and C, and writing about them in CLM, there
were fix-ups and enhancements needed, which were implemented in D
and E.  The branch is waiting to be rebased into

   A--B--C--D--E--CLM'
  /               / 
 Y----------------

which gives you a chance to talk also about D and E in the updated
iteration of CLM.

Whether the "cover letter material in an empty commit at the tip" is
a single-parent commit or a needless merge, there will be fallouts,
such as "git branch --[no-]merged" becoming much less useful.  I am
sure there will be many others once we start seriously exploring
these approaches.


  reply	other threads:[~2022-07-21 20:48 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-20 23:40 On-branch topic description support? Junio C Hamano
2022-07-21  0:52 ` Shaoxuan Yuan
2022-07-21  5:25 ` Elijah Newren
2022-07-21  6:11   ` Junio C Hamano
2022-07-21 14:41   ` Konstantin Ryabitsev
2022-07-21 16:06   ` Philip Oakley
2022-07-21 17:29     ` Junio C Hamano
2022-07-21 14:53 ` Ævar Arnfjörð Bjarmason
2022-07-21 16:26   ` Konstantin Ryabitsev
2022-07-21 17:35     ` Junio C Hamano
2022-07-21 17:51       ` Ævar Arnfjörð Bjarmason
2022-07-21 17:16   ` Junio C Hamano
2022-07-21 17:49     ` Ævar Arnfjörð Bjarmason
2022-07-21 18:02       ` Junio C Hamano
2022-07-21 18:26         ` Konstantin Ryabitsev
2022-07-21 18:58           ` Ævar Arnfjörð Bjarmason
2022-07-21 19:13           ` Konstantin Ryabitsev
2022-07-21 20:01             ` Junio C Hamano
2022-07-21 20:19               ` Konstantin Ryabitsev
2022-07-21 20:48                 ` Junio C Hamano [this message]
2022-07-21 15:05 ` Junio C Hamano
2022-07-21 15:29   ` rsbecker
2022-07-21 15:39     ` Konstantin Ryabitsev
2022-07-21 15:57       ` rsbecker
2022-07-22  3:15 ` Bagas Sanjaya

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqsfmufazi.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=konstantin@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).