From: Junio C Hamano <gitster@pobox.com>
To: Fernando Ramos <greenfoo@u92.eu>
Cc: git@vger.kernel.org, mklein994@gmail.com
Subject: Re: [PATCH] vimdiff: make layout engine more robust against user vim settings
Date: Fri, 08 Jul 2022 13:15:42 -0700 [thread overview]
Message-ID: <xmqqsfnbuzrl.fsf@gitster.g> (raw)
In-Reply-To: <20220708181024.45839-1-greenfoo@u92.eu> (Fernando Ramos's message of "Fri, 8 Jul 2022 20:10:24 +0200")
Fernando Ramos <greenfoo@u92.eu> writes:
> 'vim' has two configuration options ('splitbelow' and 'splitright') that
> change the way the 'split' command behaves. When they are set, the
> commands that the layout engine generates no longer work as expected.
Interesting. Does that mean that the end-user setting that was
problematic with the new layout engine would have also broken the
layout before your series?
> In order to fix this we can append special keyword 'letfabove' to each
Presumably "leftabove" was meant here.
> 'split' and 'vertical split' subcommand found inside the command string
> generated by the layout engine.
>
> This works because whatever comes after 'leftabove' will temporally
> ignore settings 'splitbelow' and 'splitright'.
>
> Reported-by: Matthew Klein <mklein994@gmail.com>
> Signed-off-by: Fernando Ramos <greenfoo@u92.eu>
Will queue. Thanks.
next prev parent reply other threads:[~2022-07-08 20:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-08 18:10 [PATCH] vimdiff: make layout engine more robust against user vim settings Fernando Ramos
2022-07-08 18:14 ` Fernando Ramos
2022-07-08 20:15 ` Junio C Hamano [this message]
2022-07-08 22:37 ` Fernando Ramos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqsfnbuzrl.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=greenfoo@u92.eu \
--cc=mklein994@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).