From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <git-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 12D29C43334
	for <git@archiver.kernel.org>; Fri,  8 Jul 2022 20:15:47 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S240018AbiGHUPq (ORCPT <rfc822;git@archiver.kernel.org>);
        Fri, 8 Jul 2022 16:15:46 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43170 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S238380AbiGHUPp (ORCPT <rfc822;git@vger.kernel.org>);
        Fri, 8 Jul 2022 16:15:45 -0400
Received: from pb-smtp1.pobox.com (pb-smtp1.pobox.com [64.147.108.70])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0CD3B5A2C4
        for <git@vger.kernel.org>; Fri,  8 Jul 2022 13:15:45 -0700 (PDT)
Received: from pb-smtp1.pobox.com (unknown [127.0.0.1])
        by pb-smtp1.pobox.com (Postfix) with ESMTP id 1C5C6145556;
        Fri,  8 Jul 2022 16:15:44 -0400 (EDT)
        (envelope-from junio@pobox.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=pobox.com; h=from:to:cc
        :subject:references:date:in-reply-to:message-id:mime-version
        :content-type; s=sasl; bh=L5G+KqQV1PZng8bOfmFTvEbuOwrO41eUvm2Cgp
        2dIvA=; b=KzBE2CWKlWMZ1lVDeTcD/biCt1alPDQyes5t3tJoEGOkjqLivrE2rk
        3V5GLZ0zjxcdfevkF5Q2AjxJpjOoenKea+rYTY7GkpWg4W0CRV7UBxYOmBVKmlUL
        XY7icYtHc50e9MXzJJmb0z3KRYbyEy/BM9+bzt8h3YsUQS8QwD4jY=
Received: from pb-smtp1.nyi.icgroup.com (unknown [127.0.0.1])
        by pb-smtp1.pobox.com (Postfix) with ESMTP id 13E13145555;
        Fri,  8 Jul 2022 16:15:44 -0400 (EDT)
        (envelope-from junio@pobox.com)
Received: from pobox.com (unknown [34.83.92.57])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by pb-smtp1.pobox.com (Postfix) with ESMTPSA id 7A725145554;
        Fri,  8 Jul 2022 16:15:43 -0400 (EDT)
        (envelope-from junio@pobox.com)
From:   Junio C Hamano <gitster@pobox.com>
To:     Fernando Ramos <greenfoo@u92.eu>
Cc:     git@vger.kernel.org, mklein994@gmail.com
Subject: Re: [PATCH] vimdiff: make layout engine more robust against user
 vim settings
References: <20220708181024.45839-1-greenfoo@u92.eu>
Date:   Fri, 08 Jul 2022 13:15:42 -0700
In-Reply-To: <20220708181024.45839-1-greenfoo@u92.eu> (Fernando Ramos's
        message of "Fri, 8 Jul 2022 20:10:24 +0200")
Message-ID: <xmqqsfnbuzrl.fsf@gitster.g>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Pobox-Relay-ID: BEA18F78-FEFA-11EC-986B-5E84C8D8090B-77302942!pb-smtp1.pobox.com
Precedence: bulk
List-ID: <git.vger.kernel.org>
X-Mailing-List: git@vger.kernel.org

Fernando Ramos <greenfoo@u92.eu> writes:

> 'vim' has two configuration options ('splitbelow' and 'splitright') that
> change the way the 'split' command behaves. When they are set, the
> commands that the layout engine generates no longer work as expected.

Interesting.  Does that mean that the end-user setting that was
problematic with the new layout engine would have also broken the
layout before your series?

> In order to fix this we can append special keyword 'letfabove' to each

Presumably "leftabove" was meant here.

> 'split' and 'vertical split' subcommand found inside the command string
> generated by the layout engine.
>
> This works because whatever comes after 'leftabove' will temporally
> ignore settings 'splitbelow' and 'splitright'.
>
> Reported-by: Matthew Klein <mklein994@gmail.com>
> Signed-off-by: Fernando Ramos <greenfoo@u92.eu>

Will queue.  Thanks.