From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <git-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id ED7D7C43334
	for <git@archiver.kernel.org>; Thu,  7 Jul 2022 18:27:00 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S236235AbiGGS1A (ORCPT <rfc822;git@archiver.kernel.org>);
        Thu, 7 Jul 2022 14:27:00 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53182 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S236226AbiGGS06 (ORCPT <rfc822;git@vger.kernel.org>);
        Thu, 7 Jul 2022 14:26:58 -0400
Received: from pb-smtp2.pobox.com (pb-smtp2.pobox.com [64.147.108.71])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 368E35A465
        for <git@vger.kernel.org>; Thu,  7 Jul 2022 11:26:57 -0700 (PDT)
Received: from pb-smtp2.pobox.com (unknown [127.0.0.1])
        by pb-smtp2.pobox.com (Postfix) with ESMTP id 482D8145B5A;
        Thu,  7 Jul 2022 14:26:56 -0400 (EDT)
        (envelope-from junio@pobox.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=pobox.com; h=from:to:cc
        :subject:references:date:in-reply-to:message-id:mime-version
        :content-type; s=sasl; bh=AXWSFO5WI7RtwyzkijvWB8LG92AYY9q7pJbwfU
        Yy6Jo=; b=d8x5ovL9TTETzuoS+YqImHhOe+Ta6ZH0kKBVXh8sHIDh4NFqc/H7eK
        BxF4sQIIp/VEVVSXhKk2Tq+zAfQ33NgVeahlxlh8dcvLTLKgkQROjYD+1oFxtnOe
        SCYg/Z+Bzb8lNQ6eMqzmouX12s+i7iZXGlBXXo1YyI3JXSOMXW3Uo=
Received: from pb-smtp2.nyi.icgroup.com (unknown [127.0.0.1])
        by pb-smtp2.pobox.com (Postfix) with ESMTP id 3CB06145B59;
        Thu,  7 Jul 2022 14:26:56 -0400 (EDT)
        (envelope-from junio@pobox.com)
Received: from pobox.com (unknown [34.83.92.57])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by pb-smtp2.pobox.com (Postfix) with ESMTPSA id 93831145B58;
        Thu,  7 Jul 2022 14:26:55 -0400 (EDT)
        (envelope-from junio@pobox.com)
From:   Junio C Hamano <gitster@pobox.com>
To:     Jeff King <peff@peff.net>
Cc:     Ramsay Jones <ramsay@ramsayjones.plus.com>,
        GIT Mailing-list <git@vger.kernel.org>,
        Adam Dinwoodie <adam@dinwoodie.org>,
        Johannes Schindelin <Johannes.Schindelin@gmx.de>
Subject: Re: t0301-credential-cache test failure on cygwin
References: <9dc3e85f-a532-6cff-de11-1dfb2e4bc6b6@ramsayjones.plus.com>
        <YsciDznU2TqzCXP4@coredump.intra.peff.net>
Date:   Thu, 07 Jul 2022 11:26:54 -0700
In-Reply-To: <YsciDznU2TqzCXP4@coredump.intra.peff.net> (Jeff King's message
        of "Thu, 7 Jul 2022 14:12:31 -0400")
Message-ID: <xmqqsfnczslt.fsf@gitster.g>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Pobox-Relay-ID: 614A64CC-FE22-11EC-A1DE-CB998F0A682E-77302942!pb-smtp2.pobox.com
Precedence: bulk
List-ID: <git.vger.kernel.org>
X-Mailing-List: git@vger.kernel.org

Jeff King <peff@peff.net> writes:

> Of the three, I actually like the client-side one to check errno the
> best. The client is mostly "best effort". If it can't talk to the daemon
> for whatever reason, then it becomes a noop (there is nothing it can
> retrieve from the cache, and if it's trying to write, then oh well, the
> cached value was immediately expired!).
>
> So one could argue that _every_ read error should be silently ignored.
> Calling die_errno() is mostly a nicety for debugging a broken setup, but
> in normal use, the outcome is the same either way (and Git will
> certainly ignore the exit code credential-cache anyway). I prefer the
> "ignore known harmless errors" approach, possibly because I am often the
> one debugging. ;) If ECONNABORTED is a harmless error we see in
> practice, I don't mind adding it to the list (under the same rationale
> as the current ECONNRESET that is there).

With the issue of race clearly explained, I agree that this would be
the best solution for this issue.

Thanks.