From: Junio C Hamano <gitster@pobox.com>
To: Taylor Blau <me@ttaylorr.com>
Cc: Derrick Stolee <derrickstolee@github.com>,
git@vger.kernel.org, sandals@crustytoothpaste.net
Subject: Re: [PATCH] builtin/remote.c: show progress when renaming remote references
Date: Wed, 02 Mar 2022 11:03:42 -0800 [thread overview]
Message-ID: <xmqqsfs0kwhd.fsf@gitster.g> (raw)
In-Reply-To: <Yh+Sp5BxqxYhBv0M@nand.local> (Taylor Blau's message of "Wed, 2 Mar 2022 10:52:07 -0500")
Taylor Blau <me@ttaylorr.com> writes:
> On Wed, Mar 02, 2022 at 09:32:48AM -0500, Derrick Stolee wrote:
>> > Instead of a more complex modification to the ref transaction code,
>> > display a progress meter when running verbosely in order to convince the
>> > user that Git is doing work while renaming a remote.
>>
>> Thanks for this patch. It improves the user experience through
>> useful feedback.
>
> Admittedly, it feels like a little bit of a shortcut to avoid modifying
> the ref transaction code, but I think it's an OK short-term solution.
> Thanks for reviewing.
>
>> > @@ -682,7 +686,8 @@ static int mv(int argc, const char **argv)
>> > old_remote_context = STRBUF_INIT;
>> > struct string_list remote_branches = STRING_LIST_INIT_DUP;
>> > struct rename_info rename;
>> > - int i, refspec_updated = 0;
>> > + int i, j = 0, refspec_updated = 0;
>>
>> My only complaint is that 'j' is not informative enough here.
>>
>> 'j' as a loop iterator is good, but we aren't looping "on" j,
>> but instead tracking a progress_count across multiple loops.
>
> How about s/j/refs_renamed_nr ?
Meaning "number of renamed refs"? start_progress() got the number
of remote branches to be renamed (i.e. rename.remote_branches->nr,
with symref adjustments), and approaching that ceiling from 0 by
counting the renamed ones so far makes sense.
next prev parent reply other threads:[~2022-03-02 19:03 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-01 22:20 [PATCH] builtin/remote.c: show progress when renaming remote references Taylor Blau
2022-03-02 14:32 ` Derrick Stolee
2022-03-02 15:52 ` Taylor Blau
2022-03-02 18:58 ` Derrick Stolee
2022-03-02 19:03 ` Junio C Hamano [this message]
2022-03-02 19:00 ` Ævar Arnfjörð Bjarmason
2022-03-02 22:55 ` Taylor Blau
2022-03-03 10:51 ` Ævar Arnfjörð Bjarmason
2022-03-03 19:54 ` Taylor Blau
2022-03-07 10:34 ` Han-Wen Nienhuys
2022-03-02 22:21 ` brian m. carlson
2022-03-02 22:57 ` Taylor Blau
2022-03-03 16:09 ` Derrick Stolee
2022-03-03 19:58 ` Taylor Blau
2022-03-02 23:00 ` [PATCH v2] " Taylor Blau
2022-03-03 11:04 ` Ævar Arnfjörð Bjarmason
2022-03-03 22:25 ` [PATCH v3 0/2] remote: show progress display when renaming Taylor Blau
2022-03-03 22:25 ` [PATCH v3 1/2] builtin/remote.c: parse options in 'rename' Taylor Blau
2022-03-05 14:28 ` Ævar Arnfjörð Bjarmason
2022-03-03 22:25 ` [PATCH v3 2/2] builtin/remote.c: show progress when renaming remote references Taylor Blau
2022-03-03 23:20 ` Junio C Hamano
2022-03-03 23:30 ` Taylor Blau
2022-03-05 14:31 ` Ævar Arnfjörð Bjarmason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqsfs0kwhd.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=derrickstolee@github.com \
--cc=git@vger.kernel.org \
--cc=me@ttaylorr.com \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).