From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1FFB0C433EF for ; Tue, 1 Mar 2022 17:49:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236662AbiCARue (ORCPT ); Tue, 1 Mar 2022 12:50:34 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46226 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231362AbiCARue (ORCPT ); Tue, 1 Mar 2022 12:50:34 -0500 Received: from pb-smtp1.pobox.com (pb-smtp1.pobox.com [64.147.108.70]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E354A10FF1 for ; Tue, 1 Mar 2022 09:49:52 -0800 (PST) Received: from pb-smtp1.pobox.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id 2693310F455; Tue, 1 Mar 2022 12:49:52 -0500 (EST) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=6uC5dpWJ/s4F+KwLi+Ucnn5tJQSfrGqqmPvQ1c +kqoY=; b=ZeoYTuPrOh3mxH0F8BzyIZWvFjflwRqunNFrxuDJb771TMNmvUHY4C Zt6gJ/4eGkXpNlyYOkTjPtWw3ua9ilx2o9vE/6+l1UpzMaf178SL5qZNUqDPNSge 2kTNPklCGM+2bpeJ7qh7gkiXm3KQhYTZCRaCmZO3OALaX6DgiVeSQ= Received: from pb-smtp1.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id 1DCD610F454; Tue, 1 Mar 2022 12:49:52 -0500 (EST) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [34.82.80.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp1.pobox.com (Postfix) with ESMTPSA id 7660910F453; Tue, 1 Mar 2022 12:49:51 -0500 (EST) (envelope-from junio@pobox.com) From: Junio C Hamano To: "Tao Klerks via GitGitGadget" Cc: git@vger.kernel.org, =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason , Jeff Hostetler , Tao Klerks Subject: Re: [PATCH v2 0/2] Reduce explicit sleep calls in t7063 untracked cache tests References: Date: Tue, 01 Mar 2022 09:49:50 -0800 In-Reply-To: (Tao Klerks via GitGitGadget's message of "Tue, 01 Mar 2022 09:45:08 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: FEBC5EA4-9987-11EC-BB7A-5E84C8D8090B-77302942!pb-smtp1.pobox.com Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org "Tao Klerks via GitGitGadget" writes: > As noted in a recent proposed patch to t/t7519-status-fsmonitor.sh, a number > of test cases in t\t7063-status-untracked-cache.sh explicitly sleep a > second, in order to avoid the untracked cache content being invalidated by > an mtime race condition. > > Even though it's only 9 seconds of sleeping that can be straightforwardly > replaced, it seems worth fixing if possible. Absolutely. Thanks for an update.