From: Junio C Hamano <gitster@pobox.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: Taylor Blau <me@ttaylorr.com>, Birk Tjelmeland <git@birktj.no>,
git@vger.kernel.org
Subject: Re: [PATCH] stash: show error message when lockfile is present
Date: Mon, 08 Nov 2021 12:05:36 -0800 [thread overview]
Message-ID: <xmqqsfw6tnu7.fsf@gitster.g> (raw)
In-Reply-To: <211108.868rxyfote.gmgdl@evledraar.gmail.com> ("Ævar Arnfjörð Bjarmason"'s message of "Mon, 08 Nov 2021 20:05:47 +0100")
Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
> The "quiet" here is orthagonal, it's to disable the chatty output from
> read-cache.c.
It shouldn't be. read-cache.c may want to report errors and
progresses, and among the errors it may not include lock-related
things. If the change were to (1) extend the flag word to make it
more uniform, so that it does not special case ONLY the lock-related
errors, and to (2) figure out how to grab richer diagnoses out of
the lower level API functions, and to (3) reduce the messages issued
by the lower-level API functions and have it callers' responsibility
to give the messages, that would have been palatable, but the patch
as posted goes totally the opposite direction on all these points.
Yuck.
next prev parent reply other threads:[~2021-11-08 20:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-07 21:30 [PATCH] stash: show error message when lockfile is present Birk Tjelmeland
2021-11-08 3:21 ` Taylor Blau
2021-11-08 4:15 ` Taylor Blau
2021-11-08 7:10 ` Junio C Hamano
2021-11-08 17:56 ` Taylor Blau
2021-11-08 19:05 ` Ævar Arnfjörð Bjarmason
2021-11-08 20:05 ` Junio C Hamano [this message]
2021-11-08 20:35 ` Birk Tjelmeland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqsfw6tnu7.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=git@birktj.no \
--cc=git@vger.kernel.org \
--cc=me@ttaylorr.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).