From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 1/2] send-pack: complain about "expecting report" with --helper-status
Date: Mon, 18 Oct 2021 13:26:22 -0700 [thread overview]
Message-ID: <xmqqsfwyuljl.fsf@gitster.g> (raw)
In-Reply-To: <YW3OcxqcOsY9AFQ8@coredump.intra.peff.net> (Jeff King's message of "Mon, 18 Oct 2021 15:43:47 -0400")
Jeff King <peff@peff.net> writes:
> diff --git a/builtin/send-pack.c b/builtin/send-pack.c
> index 8932142312..69c432ef1a 100644
> --- a/builtin/send-pack.c
> +++ b/builtin/send-pack.c
> @@ -87,6 +87,10 @@ static void print_helper_status(struct ref *ref)
> break;
>
> case REF_STATUS_EXPECTING_REPORT:
> + res = "error";
> + msg = "expecting report";
> + break;
> +
> default:
> continue;
> }
That is obviously correct, minimum and surprisingly simple ;-)
Thanks.
next prev parent reply other threads:[~2021-10-18 20:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-18 19:34 [PATCH 0/2] handling REF_STATUS_EXPECTING_REPORT over http Jeff King
2021-10-18 19:43 ` [PATCH 1/2] send-pack: complain about "expecting report" with --helper-status Jeff King
2021-10-18 20:26 ` Junio C Hamano [this message]
2021-10-18 19:45 ` [PATCH 2/2] transport-helper: recognize "expecting report" error from send-pack Jeff King
2021-10-19 23:58 ` [PATCH 0/2] handling REF_STATUS_EXPECTING_REPORT over http brian m. carlson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqsfwyuljl.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).