From: Junio C Hamano <gitster@pobox.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: "Jiang Xin" <worldhello.net@gmail.com>,
"Git List" <git@vger.kernel.org>,
"Alexander Shopov" <ash@kambanaria.org>,
"Jordi Mas" <jmas@softcatala.org>,
"Matthias Rüster" <matthias.ruester@gmail.com>,
"Jimmy Angelakos" <vyruss@hellug.gr>,
"Christopher Díaz" <christopher.diaz.riv@gmail.com>,
"Jean-Noël Avila" <jn.avila@free.fr>,
"Bagas Sanjaya" <bagasdotme@gmail.com>,
"Alessandro Menti" <alessandro.menti@alessandromenti.it>,
"Gwan-gyeong Mun" <elongbug@gmail.com>, Arusekk <arek_koz@o2.pl>,
"Daniel Santos" <hello@brighterdan.com>,
"Dimitriy Ryazantcev" <DJm00n@mail.ru>,
"Peter Krefting" <peter@softwolves.pp.se>,
"Emir SARI" <bitigchi@me.com>,
"Trần Ngọc Quân" <vnwildman@gmail.com>,
"Fangyi Zhou" <me@fangyi.io>, "Yi-Jyun Pan" <pan93412@gmail.com>,
"Jiang Xin" <zhiyou.jx@alibaba-inc.com>
Subject: Re: [PATCH 1/1] ci: new github-action for git-l10n code review
Date: Mon, 23 Aug 2021 14:36:21 -0700 [thread overview]
Message-ID: <xmqqsfyzq1wq.fsf@gitster.g> (raw)
In-Reply-To: <nycvar.QRO.7.76.6.2108232232460.55@tvgsbejvaqbjf.bet> (Johannes Schindelin's message of "Mon, 23 Aug 2021 23:02:50 +0200 (CEST)")
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
>> For a push event, it will scan commits one by one. If a commit does not
>> look like a l10n commit (no file in "po/" has been changed), it will
>> immediately fail without checking for further commits. While for a
>> pull_request event, all new introduced commits will be scanned.
>>
>> "git-po-helper" will generate two kinds of suggestions, errors and
>> warnings. A l10n contributor should try to fix all the errors, and
>> should pay attention to the warnings. All the errors and warnings will
>> be reported in the last step of the l10n workflow as two message groups.
>> For a pull_request event, will create additional comments in pull
>> request to report the result.
>
> It is a good idea to automate this.
>
> I am a bit concerned that the `ci-config` approach, even if we use it in
> the Git project itself, is quite cumbersome to use, though. So I hope that
> we can find an alternative solution.
>
> One such solution could be to make the `git-po-helper` job contingent on
> part of the repository name. For example:
>
> git-po-helper:
> if: endsWith(github.repository, '/git-po')
> [...]
>
> would skip the job unless the target repository's name is `git-po`.
Nice.
Can this be made into a matter purely local to git-l10n/git-po
repository and not git/git repository? I am wondering if we can ee
if the current repository is git-l10n/git-po or its fork and run it
only if that is true.
Thanks.
next prev parent reply other threads:[~2021-08-23 21:43 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-22 16:13 [PATCH 0/1] ci: new github-action for git-l10n code review Jiang Xin
2021-08-22 16:13 ` [PATCH 1/1] " Jiang Xin
2021-08-23 6:28 ` Bagas Sanjaya
2021-08-23 6:42 ` Jiang Xin
2021-08-23 21:02 ` Johannes Schindelin
2021-08-23 21:36 ` Junio C Hamano [this message]
2021-08-24 9:27 ` Johannes Schindelin
2021-08-24 19:04 ` Junio C Hamano
2021-08-24 21:34 ` Jean-Noël AVILA
2021-08-31 1:03 ` Jiang Xin
2021-08-24 13:36 ` Jiang Xin
2021-08-24 19:06 ` Junio C Hamano
2021-08-24 13:21 ` Jiang Xin
2021-08-25 12:14 ` Johannes Schindelin
2021-08-26 2:25 ` Jiang Xin
2021-08-27 2:10 ` Jeff King
2021-08-27 2:49 ` Jiang Xin
2021-08-27 7:13 ` [PATCH v3] " Jiang Xin
2021-09-02 2:31 ` [PATCH v4 0/1] " Jiang Xin
2021-09-09 9:09 ` [PATCH v5 " Jiang Xin
2021-09-09 9:09 ` [PATCH v5 1/1] " Jiang Xin
2021-09-02 2:31 ` [PATCH v4 " Jiang Xin
2021-08-23 14:28 ` [PATCH v2 0/1] " Jiang Xin
2021-08-23 14:28 ` [PATCH v2 1/1] " Jiang Xin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqsfyzq1wq.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=DJm00n@mail.ru \
--cc=Johannes.Schindelin@gmx.de \
--cc=alessandro.menti@alessandromenti.it \
--cc=arek_koz@o2.pl \
--cc=ash@kambanaria.org \
--cc=bagasdotme@gmail.com \
--cc=bitigchi@me.com \
--cc=christopher.diaz.riv@gmail.com \
--cc=elongbug@gmail.com \
--cc=git@vger.kernel.org \
--cc=hello@brighterdan.com \
--cc=jmas@softcatala.org \
--cc=jn.avila@free.fr \
--cc=matthias.ruester@gmail.com \
--cc=me@fangyi.io \
--cc=pan93412@gmail.com \
--cc=peter@softwolves.pp.se \
--cc=vnwildman@gmail.com \
--cc=vyruss@hellug.gr \
--cc=worldhello.net@gmail.com \
--cc=zhiyou.jx@alibaba-inc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).