From: Junio C Hamano <gitster@pobox.com>
To: Carlo Arenas <carenas@gmail.com>
Cc: "Đoàn Trần Công Danh" <congdanhqx@gmail.com>,
git@vger.kernel.org, "Thomas De Zeeuw" <thomas@slight.dev>
Subject: Re: [PATCH] diff-lib: ignore all outsider if --relative asked
Date: Thu, 19 Aug 2021 09:58:16 -0700 [thread overview]
Message-ID: <xmqqsfz52wyf.fsf@gitster.g> (raw)
In-Reply-To: <CAPUEspg+LUP59DJ+Z-AqKW0hfz=AbMfvOTFLe1rT5g5auV7gdA@mail.gmail.com> (Carlo Arenas's message of "Thu, 19 Aug 2021 02:02:43 -0700")
Carlo Arenas <carenas@gmail.com> writes:
> My only concern is that it seems this has been broken for a while
> (couldn't bisect, but AFAIK the first implementation did filter like
> this one does), so some people might be expecting the broken
> behaviour.
I do not think it is likely.
It only shows changes to unmerged paths outside the current
directory, which does not sound all that useful.
next prev parent reply other threads:[~2021-08-19 16:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-21 4:03 [PATCH v2] diff-lib: ignore all outsider if --relative asked Đoàn Trần Công Danh
2021-08-18 8:42 ` Bug: Segmentation fault in git diff Thomas De Zeeuw
2021-08-18 10:44 ` Đoàn Trần Công Danh
2021-08-18 12:52 ` Đoàn Trần Công Danh
2021-08-18 20:30 ` Junio C Hamano
2021-08-19 8:29 ` [PATCH] diff-lib: ignore all outsider if --relative asked Đoàn Trần Công Danh
2021-08-19 9:02 ` Carlo Arenas
2021-08-19 16:58 ` Junio C Hamano [this message]
2021-08-19 16:55 ` Junio C Hamano
2021-08-22 8:49 ` [PATCH v3] " Đoàn Trần Công Danh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqsfz52wyf.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=carenas@gmail.com \
--cc=congdanhqx@gmail.com \
--cc=git@vger.kernel.org \
--cc=thomas@slight.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).