git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: "René Scharfe" <l.s.r@web.de>,
	"Felipe Contreras" <felipe.contreras@gmail.com>,
	git@vger.kernel.org,
	"Johannes Schindelin" <Johannes.Schindelin@gmx.de>
Subject: Re: [PATCH] gitignore: remove entry for git serve
Date: Wed, 02 Dec 2020 14:32:02 -0800	[thread overview]
Message-ID: <xmqqsg8nltzx.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <X8eNGzay6yWSEoJH@coredump.intra.peff.net> (Jeff King's message of "Wed, 2 Dec 2020 07:48:27 -0500")

Jeff King <peff@peff.net> writes:

> On Wed, Dec 02, 2020 at 12:46:01PM +0100, René Scharfe wrote:
>
>> b7ce24d095 (Turn `git serve` into a test helper, 2019-04-18) demoted git
>> serve from a builtin command to a test helper.  As a result the
>> git-serve binary is no longer built and thus doesn't have to be ignored
>> anymore.
>
> Good catch. This shows a weakness in my detection script: I had a stale
> git-serve sitting around from building old versions of Git. :)
>
> I repeated the script in a "clean" directory that was a fresh clone +
> make, and diffed the results. git-serve was the only interesting
> difference I saw. So this is probably the last of the low-hanging fruit.

Thanks, all.  

Just for simplicity, these two are also queued on the same "random
cleanup" topic branch started with Felipe's four trivial clean-up
patches.

  reply	other threads:[~2020-12-02 22:33 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-01  0:46 [PATCH 0/4] Random cleanups Felipe Contreras
2020-12-01  0:46 ` [PATCH 1/4] refspec: trivial cleanup Felipe Contreras
2020-12-01 11:43   ` Jeff King
2020-12-01 18:29     ` Junio C Hamano
2020-12-01 23:25     ` Felipe Contreras
2020-12-02  2:01       ` Jeff King
2020-12-02  2:27         ` Felipe Contreras
2020-12-01  0:46 ` [PATCH 2/4] .gitignore: remove dangling file Felipe Contreras
2020-12-01 18:30   ` Junio C Hamano
2020-12-01 23:32     ` Felipe Contreras
2020-12-02  2:26     ` Jeff King
2020-12-02  3:30       ` Felipe Contreras
2020-12-02 11:46       ` [PATCH] gitignore: remove entry for git serve René Scharfe
2020-12-02 11:03         ` Johannes Schindelin
2020-12-02 12:48         ` Jeff King
2020-12-02 22:32           ` Junio C Hamano [this message]
2020-12-01  0:46 ` [PATCH 3/4] test: completion: fix typos Felipe Contreras
2020-12-01  0:46 ` [PATCH 4/4] tests: lib-functions: trivial style cleanups Felipe Contreras

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqsg8nltzx.fsf@gitster.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=felipe.contreras@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=l.s.r@web.de \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).