* tig: bug when binding to 'generic'? @ 2020-05-02 19:04 Wolfram Sang 2020-05-02 19:07 ` Kevin Daudt 0 siblings, 1 reply; 6+ messages in thread From: Wolfram Sang @ 2020-05-02 19:04 UTC (permalink / raw) To: git; +Cc: Thomas Koutcher, Jonas Fonseca [-- Attachment #1: Type: text/plain, Size: 426 bytes --] Hi, here is a minimal, problematic .tigrc: === bind generic F !echo "Hello World!" === This works for most views, but not for 'main' where it still toggles the refs. Adding a specific 'main' binding works: === bind main F !echo "Hello World!" === It also works if I bind the 'generic' command to an unused key, e.g. '4'. Discovered with Debian's 2.4.1, but confirmed against HEAD of today. A bug? Thanks, Wolfram [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: tig: bug when binding to 'generic'? 2020-05-02 19:04 tig: bug when binding to 'generic'? Wolfram Sang @ 2020-05-02 19:07 ` Kevin Daudt 2020-05-02 19:31 ` Wolfram Sang 0 siblings, 1 reply; 6+ messages in thread From: Kevin Daudt @ 2020-05-02 19:07 UTC (permalink / raw) To: Wolfram Sang; +Cc: git, Thomas Koutcher, Jonas Fonseca On Sat, May 02, 2020 at 09:04:33PM +0200, Wolfram Sang wrote: > Hi, > > here is a minimal, problematic .tigrc: > > === > bind generic F !echo "Hello World!" > === > > This works for most views, but not for 'main' where it still toggles the > refs. Adding a specific 'main' binding works: > > === > bind main F !echo "Hello World!" > === > > It also works if I bind the 'generic' command to an unused key, e.g. '4'. > > Discovered with Debian's 2.4.1, but confirmed against HEAD of today. > > A bug? > > Thanks, > > Wolfram > Hello Wolfram, Tig is a third-party interface, not maintained by git. You can report issues for tig on [github][0] Kind regards, Kevin [0]:https://github.com/jonas/tig/issues ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: tig: bug when binding to 'generic'? 2020-05-02 19:07 ` Kevin Daudt @ 2020-05-02 19:31 ` Wolfram Sang 2020-05-04 22:05 ` Taylor Blau 0 siblings, 1 reply; 6+ messages in thread From: Wolfram Sang @ 2020-05-02 19:31 UTC (permalink / raw) To: Kevin Daudt, Wolfram Sang, git, Thomas Koutcher, Jonas Fonseca [-- Attachment #1: Type: text/plain, Size: 429 bytes --] Hi Kevin, > Tig is a third-party interface, not maintained by git. You can report > issues for tig on [github][0] I know it is third-party. Seems the README in tig needs fixing, too: === Bugs and feature requests can be reported using the issue tracker or by mail to either the Git mailing list or directly to the maintainer. == I prefer the mail option, so I wrote here and CCed the maintainers. Kind regards, Wolfram [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: tig: bug when binding to 'generic'? 2020-05-02 19:31 ` Wolfram Sang @ 2020-05-04 22:05 ` Taylor Blau 2020-05-04 23:01 ` Junio C Hamano 0 siblings, 1 reply; 6+ messages in thread From: Taylor Blau @ 2020-05-04 22:05 UTC (permalink / raw) To: Wolfram Sang Cc: Kevin Daudt, Wolfram Sang, git, Thomas Koutcher, Jonas Fonseca On Sat, May 02, 2020 at 09:31:02PM +0200, Wolfram Sang wrote: > Hi Kevin, > > > Tig is a third-party interface, not maintained by git. You can report > > issues for tig on [github][0] > > I know it is third-party. Seems the README in tig needs fixing, too: > > === > Bugs and feature requests can be reported using the issue tracker or by > mail to either the Git mailing list or directly to the maintainer. > == > > I prefer the mail option, so I wrote here and CCed the maintainers. Thanks for clarifying. I was a little confused when I read your patch series, since on first blush I thought that you were submitting it to be applied in Git's integration branches, and not Tig's. In either case, the heads-up is appreciated, but I do not think necessary in general. I am not sure about the feelings of others, but I do not think Tig-specific bugs need to be reported on Git's mailing list. Of course, if there are Git bugs that affect Tig (or any other project), we would be interested in hearing about them. That's all to say that I think the README there should be updated. > Kind regards, > > Wolfram > Thanks, Taylor ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: tig: bug when binding to 'generic'? 2020-05-04 22:05 ` Taylor Blau @ 2020-05-04 23:01 ` Junio C Hamano 2020-05-04 23:14 ` Taylor Blau 0 siblings, 1 reply; 6+ messages in thread From: Junio C Hamano @ 2020-05-04 23:01 UTC (permalink / raw) To: Taylor Blau Cc: Wolfram Sang, Kevin Daudt, Wolfram Sang, git, Thomas Koutcher, Jonas Fonseca Taylor Blau <me@ttaylorr.com> writes: > Thanks for clarifying. I was a little confused when I read your patch > series, since on first blush I thought that you were submitting it to be > applied in Git's integration branches, and not Tig's. > > In either case, the heads-up is appreciated, but I do not think > necessary in general. I am not sure about the feelings of others, but I > do not think Tig-specific bugs need to be reported on Git's mailing > list. > > Of course, if there are Git bugs that affect Tig (or any other project), > we would be interested in hearing about them. > > That's all to say that I think the README there should be updated. FWIW, I do not mind seeing tig related improvements discussed here (I am assuming tig does not have its own development list). That is how we've been operating with other "projects around Git", like "imerge" and "tbdiff" (no need to look for the latter these days, though). Unless Jonas and others who are involved find the list traffic here is too heavy and messages about tig will be drowned in here, I do not see a reason to kick them out. ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: tig: bug when binding to 'generic'? 2020-05-04 23:01 ` Junio C Hamano @ 2020-05-04 23:14 ` Taylor Blau 0 siblings, 0 replies; 6+ messages in thread From: Taylor Blau @ 2020-05-04 23:14 UTC (permalink / raw) To: Junio C Hamano Cc: Taylor Blau, Wolfram Sang, Kevin Daudt, Wolfram Sang, git, Thomas Koutcher, Jonas Fonseca On Mon, May 04, 2020 at 04:01:40PM -0700, Junio C Hamano wrote: > Taylor Blau <me@ttaylorr.com> writes: > > > Thanks for clarifying. I was a little confused when I read your patch > > series, since on first blush I thought that you were submitting it to be > > applied in Git's integration branches, and not Tig's. > > > > In either case, the heads-up is appreciated, but I do not think > > necessary in general. I am not sure about the feelings of others, but I > > do not think Tig-specific bugs need to be reported on Git's mailing > > list. > > > > Of course, if there are Git bugs that affect Tig (or any other project), > > we would be interested in hearing about them. > > > > That's all to say that I think the README there should be updated. > > FWIW, I do not mind seeing tig related improvements discussed here > (I am assuming tig does not have its own development list). That is > how we've been operating with other "projects around Git", like > "imerge" and "tbdiff" (no need to look for the latter these days, > though). Ah, fair enough: I do remember seeing an imerge query on the list a couple of days (weeks?) ago. > Unless Jonas and others who are involved find the list traffic here > is too heavy and messages about tig will be drowned in here, I do > not see a reason to kick them out. OK, that sounds good (it wasn't really up to me anyway, but I'm glad that I know how you feel about the matter ;)). Thanks, Taylor ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-05-04 23:14 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2020-05-02 19:04 tig: bug when binding to 'generic'? Wolfram Sang 2020-05-02 19:07 ` Kevin Daudt 2020-05-02 19:31 ` Wolfram Sang 2020-05-04 22:05 ` Taylor Blau 2020-05-04 23:01 ` Junio C Hamano 2020-05-04 23:14 ` Taylor Blau
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).