From: Junio C Hamano <gitster@pobox.com>
To: "René Scharfe" <l.s.r@web.de>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH] tests: remove "cat foo" before "test_i18ngrep bar foo"
Date: Mon, 07 Oct 2019 10:19:08 +0900 [thread overview]
Message-ID: <xmqqsgo54ak3.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <d178227d-7658-8c49-a147-e88d31c713e3@web.de> ("René Scharfe"'s message of "Sun, 6 Oct 2019 15:26:42 +0200")
René Scharfe <l.s.r@web.de> writes:
> Some tests print a file before searching for a pattern using
> test_i18ngrep. This is useful when debugging tests with --verbose when
> the pattern is not found as expected.
>
> Since 63b1a175ee (t: make 'test_i18ngrep' more informative on failure,
> 2018-02-08) test_i18ngrep already shows the contents of a file that
> doesn't match the expected pattern, though.
>
> So don't bother doing the same unconditionally up-front. The contents
> are not interesting if the expected pattern is found, and showing it
> twice if it doesn't match is of no use.
>
> Signed-off-by: René Scharfe <l.s.r@web.de>
> ---
> Almost formatted it using -U1..
Yeah, that's tempting ;-)
Thanks. All looked good.
prev parent reply other threads:[~2019-10-07 1:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-06 13:26 [PATCH] tests: remove "cat foo" before "test_i18ngrep bar foo" René Scharfe
2019-10-07 1:19 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqsgo54ak3.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=l.s.r@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).