git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org
Subject: Re: jk/test-commit-bulk,
Date: Tue, 23 Jul 2019 08:42:00 -0700	[thread overview]
Message-ID: <xmqqsgqwu59z.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20190719215417.GA31841@sigill.intra.peff.net> (Jeff King's message of "Fri, 19 Jul 2019 17:54:17 -0400")

Jeff King <peff@peff.net> writes:

>>  Needs a bit more polishing.
>>  I think I spotted one unused command, which we may want to remove, though.
>
> I think these comments are out-of-date. The unused command was fixed up
> in v2 of the first patch, and then I did a little extra polishing in v3:
>
>   https://public-inbox.org/git/20190702051649.GA16344@sigill.intra.peff.net/

Thanks, indeed.  I've been a bit under the weather and my responses
may be a bit slow (haven't caught up with my mailbox, either X-<).

Will replace.  Thanks for all the help.

>
> Together with your SQUASH fixup, I think that covers all comments. For
> convenience, here's v3 again as a whole series which can replace what
> you have already (including the squash).
>
>   [1/6]: test-lib: introduce test_commit_bulk
>   [2/6]: t5310: increase the number of bitmapped commits
>   [3/6]: t3311: use test_commit_bulk
>   [4/6]: t5702: use test_commit_bulk
>   [5/6]: t5703: use test_commit_bulk
>   [6/6]: t6200: use test_commit_bulk
>
>  t/t3311-notes-merge-fanout.sh      |  10 +--
>  t/t5310-pack-bitmaps.sh            |  15 +---
>  t/t5702-protocol-v2.sh             |  10 +--
>  t/t5703-upload-pack-ref-in-want.sh |   4 +-
>  t/t6200-fmt-merge-msg.sh           |   7 +-
>  t/test-lib-functions.sh            | 123 +++++++++++++++++++++++++++++
>  6 files changed, 136 insertions(+), 33 deletions(-)
>
> -Peff

      parent reply	other threads:[~2019-07-23 15:42 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-19 20:27 What's cooking in git.git (Jul 2019, #05; Fri, 19) Junio C Hamano
2019-07-19 21:54 ` jk/test-commit-bulk, was: " Jeff King
2019-07-19 21:56   ` [PATCH v3 1/6] test-lib: introduce test_commit_bulk Jeff King
2019-07-19 21:56   ` [PATCH v3 2/6] t5310: increase the number of bitmapped commits Jeff King
2019-07-19 21:56   ` [PATCH v3 3/6] t3311: use test_commit_bulk Jeff King
2019-07-19 21:56   ` [PATCH v3 4/6] t5702: " Jeff King
2019-07-19 21:56   ` [PATCH v3 5/6] t5703: " Jeff King
2019-07-19 21:56   ` [PATCH v3 6/6] t6200: " Jeff King
2019-07-23 15:42   ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqsgqwu59z.fsf@gitster-ct.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).