From: Junio C Hamano <gitster@pobox.com>
To: Jens Lehmann <Jens.Lehmann@web.de>
Cc: git@vger.kernel.org, Michal Sojka <sojkam1@fel.cvut.cz>
Subject: Re: [PATCH] submodule: Fix documentation of update subcommand
Date: Mon, 03 Nov 2014 12:53:14 -0800 [thread overview]
Message-ID: <xmqqsii0qa4l.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <xmqqegtkrtt9.fsf@gitster.dls.corp.google.com> (Junio C. Hamano's message of "Mon, 03 Nov 2014 11:02:42 -0800")
I did a bit more digging of the history, and came up with this,
which would be with a clearer and fairer description. Also to
clarify, I spelled what Michal's "This" meant to refer to.
-- >8 --
From: Michal Sojka <sojkam1@fel.cvut.cz>
Date: Mon, 3 Nov 2014 11:09:51 +0100
Subject: [PATCH] submodule: clarify documentation for update subcommand
e6a1c43a (document submdule.$name.update=none option for gitmodules,
2012-05-10) meant to say "Unlike the case where your .update
configuration is set to either 'rebase' or 'merge', when it is set
to 'none', the tip of the submodule would never move. You can use
the --checkout option if you want the contents of the submodule to
be updated to some other commit."
But the resulting text made it sound as if using "--checkout" would
have no effect when .update configuration is set to 'rebase' or
'merge', which was misleading. In fact, with the "--checkout"
option, the tip of the submodule moves to the exact commit that is
recorded in the superproject tree, regardless of .update
configuration.
Signed-off-by: Michal Sojka <sojkam1@fel.cvut.cz>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
Documentation/git-submodule.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/git-submodule.txt b/Documentation/git-submodule.txt
index 8e6af65..648323f 100644
--- a/Documentation/git-submodule.txt
+++ b/Documentation/git-submodule.txt
@@ -158,7 +158,7 @@ update::
checkout the commit specified in the index of the containing repository.
This will make the submodules HEAD be detached unless `--rebase` or
`--merge` is specified or the key `submodule.$name.update` is set to
- `rebase`, `merge` or `none`. `none` can be overridden by specifying
+ `rebase`, `merge` or `none`. The configuration can be overridden by specifying
`--checkout`. Setting the key `submodule.$name.update` to `!command`
will cause `command` to be run. `command` can be any arbitrary shell
command that takes a single argument, namely the sha1 to update to.
--
2.2.0-rc0-43-g5b91d12
next prev parent reply other threads:[~2014-11-03 20:53 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-03 10:09 [PATCH] submodule: Fix documentation of update subcommand Michal Sojka
2014-11-03 19:02 ` Junio C Hamano
2014-11-03 20:38 ` Jens Lehmann
2014-11-03 21:35 ` Junio C Hamano
2014-11-03 22:55 ` Michal Sojka
2014-11-03 23:08 ` Junio C Hamano
2014-11-04 20:22 ` Jens Lehmann
2014-11-04 20:56 ` Junio C Hamano
2014-11-03 20:53 ` Junio C Hamano [this message]
2014-11-03 20:58 ` Jens Lehmann
2015-02-17 22:45 ` Junio C Hamano
2015-02-18 22:48 ` [PATCH v2] " Michal Sojka
2015-02-18 23:44 ` Junio C Hamano
2015-02-19 17:54 ` Michal Sojka
2015-02-19 18:52 ` [PATCH v3] submodule: Improve " Michal Sojka
2015-02-20 23:31 ` Junio C Hamano
2015-02-23 13:31 ` Michal Sojka
2015-02-23 13:32 ` [PATCH] " Michal Sojka
2015-02-23 20:13 ` Junio C Hamano
2015-02-23 20:25 ` Junio C Hamano
2015-03-02 22:39 ` Michal Sojka
2015-03-02 22:42 ` [PATCH v5] " Michal Sojka
2015-03-02 22:57 ` [PATCH v6] " Michal Sojka
2015-03-02 23:05 ` Junio C Hamano
2014-11-03 21:15 ` [PATCH] submodule: Fix " Michal Sojka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqsii0qa4l.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=Jens.Lehmann@web.de \
--cc=git@vger.kernel.org \
--cc=sojkam1@fel.cvut.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).