* Is column.ui.* configuration a bit too strong?
@ 2014-06-23 19:03 Junio C Hamano
2014-06-24 12:00 ` Duy Nguyen
0 siblings, 1 reply; 2+ messages in thread
From: Junio C Hamano @ 2014-06-23 19:03 UTC (permalink / raw)
To: Nguyễn Thái Ngọc Duy; +Cc: git
Since its inception at 7e29b825 (Add column layout skeleton and
git-column, 2012-04-21), it seems that git_column_config() asked for
a specific $command did not give "column.$command.*" any precedence
over the fallback value defined for "column.ui.*". If you happen to
have column.ui.* earlier than the corresponding column.$command.* in
your configuration, then the values come from column.ui.* may be
overwritten, but the code does not seem to enforce "if there is a
setting for a specific command, honor that, otherwise fall back to
the generic 'ui' setting".
Am I misreading the code?
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Is column.ui.* configuration a bit too strong?
2014-06-23 19:03 Is column.ui.* configuration a bit too strong? Junio C Hamano
@ 2014-06-24 12:00 ` Duy Nguyen
0 siblings, 0 replies; 2+ messages in thread
From: Duy Nguyen @ 2014-06-24 12:00 UTC (permalink / raw)
To: Junio C Hamano; +Cc: Git Mailing List
On Tue, Jun 24, 2014 at 2:03 AM, Junio C Hamano <gitster@pobox.com> wrote:
> Since its inception at 7e29b825 (Add column layout skeleton and
> git-column, 2012-04-21), it seems that git_column_config() asked for
> a specific $command did not give "column.$command.*" any precedence
> over the fallback value defined for "column.ui.*". If you happen to
> have column.ui.* earlier than the corresponding column.$command.* in
> your configuration, then the values come from column.ui.* may be
> overwritten, but the code does not seem to enforce "if there is a
> setting for a specific command, honor that, otherwise fall back to
> the generic 'ui' setting".
>
> Am I misreading the code?
Hmm.. probably not. The way I read it, the git_column_config() relies
on the order that git_config() calls it, which should be "undefined
order" from git_column_config point of view.
--
Duy
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-06-24 12:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-23 19:03 Is column.ui.* configuration a bit too strong? Junio C Hamano
2014-06-24 12:00 ` Duy Nguyen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).