From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] pack-objects: do not reuse packfiles without --delta-base-offset
Date: Fri, 04 Apr 2014 15:28:48 -0700 [thread overview]
Message-ID: <xmqqsipsohjz.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20140404214848.GA23666@sigill.intra.peff.net> (Jeff King's message of "Fri, 4 Apr 2014 17:48:49 -0400")
Jeff King <peff@peff.net> writes:
> We could convert OFS_DELTA to REF_DELTA on the fly. That _may_ have a
> performance impact. Right now, we are basically doing the equivalent of
> sendfile(), and conversion would involve iterating through each object
> and examining the header. I think that's probably not too bad, though.
> The most expensive part of that, stepping to the next object, requires
> scanning through the zlib packets, but we should be able to use the
> revidx to avoid that.
>
> I'm not sure it's even worth the code complexity, though. The non-reuse
> codepath is not that much slower, and it should be extremely rare for a
> client not to support OFS_DELTA these days.
OK, together with the fact that only ancient versions of fetcher
would trigger this "do not reuse" codepath, I agree that we should
go the simplest route this patch takes.
Thanks.
next prev parent reply other threads:[~2014-04-04 22:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-02 6:39 [PATCH] pack-objects: do not reuse packfiles without --delta-base-offset Jeff King
2014-04-02 17:39 ` Junio C Hamano
2014-04-04 21:48 ` Jeff King
2014-04-04 22:28 ` Junio C Hamano [this message]
2014-04-04 23:13 ` Jeff King
2014-04-07 17:15 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqsipsohjz.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).