From: Junio C Hamano <gitster@pobox.com>
To: Duy Nguyen <pclouds@gmail.com>
Cc: 孙赫 <sunheehnus@gmail.com>, git <git@vger.kernel.org>,
"Michael Haggerty" <mhagger@alum.mit.edu>
Subject: Re: [PATCH] OPTION_CMDMODE should be used when not accept an argument, and OPTION_NUMBER is of special type. So change the mode to OPTION_CMDMODE
Date: Fri, 28 Feb 2014 12:02:04 -0800 [thread overview]
Message-ID: <xmqqsir3t39f.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <CACsJy8BM=m6=tv2P6F3EAcVPupovSTKC3s+5gkus3V+GZ4owRw@mail.gmail.com> (Duy Nguyen's message of "Fri, 28 Feb 2014 21:42:21 +0700")
Duy Nguyen <pclouds@gmail.com> writes:
> Way too long subject line. Keep it within 70-75 chars. The rest could
> be put in the body.
>
> On Fri, Feb 28, 2014 at 9:32 PM, 孙赫 <sunheehnus@gmail.com> wrote:
>> I am not sure if this is a bug.
>> I need your help to find out it.
>
> Tip:git has a wonderful history (most of it anyway). Try "git log
> --patch parse-options.[ch]" to understand parse-options evolution. Add
> -SOPTION_NUMBER (or -SOPTION_CMDMODE) to limit to only commits whose
> diff contains that keyword.
Also, I do not think this should be done in a single patch. What if
it turns out that explicitly making sure that CMDMODE does not take
any argument is a good idea, but the other change is a bad one?
next prev parent reply other threads:[~2014-02-28 20:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-28 14:29 [PATCH] OPTION_CMDMODE should be used when not accept an argument, and OPTION_NUMBER is of special type. So change the mode to OPTION_CMDMODE Sun He
2014-02-28 14:32 ` 孙赫
2014-02-28 14:42 ` Duy Nguyen
2014-02-28 15:21 ` 孙赫
2014-02-28 20:02 ` Junio C Hamano [this message]
2014-02-28 23:50 ` He Sun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqsir3t39f.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=mhagger@alum.mit.edu \
--cc=pclouds@gmail.com \
--cc=sunheehnus@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox