From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: kristofferhaugsbakk@fastmail.com, git@vger.kernel.org,
Kristoffer Haugsbakk <code@khaugsbakk.name>
Subject: Re: [PATCH] trailers: stop recognizing URLs as trailers
Date: Mon, 03 Aug 2026 08:39:10 -0700 [thread overview]
Message-ID: <xmqqtspbz00x.fsf@gitster.g> (raw)
In-Reply-To: <20260803152025.GA189075@coredump.intra.peff.net> (Jeff King's message of "Mon, 3 Aug 2026 11:20:25 -0400")
Jeff King <peff@peff.net> writes:
> As discussed elsewhere, we are free to match with short-circuiting
> because of the NUL termination. But that also means we could write this
> as:
>
> if (starts_with(c, "://") && !whitespace_found)
>
> which is perhaps a little more readable.
"little more" -> "much more" ;-).
next prev parent reply other threads:[~2026-08-03 15:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-04 21:27 trailers: --only-trailers normalizes URLs to trailers Kristoffer Haugsbakk
2026-06-09 0:43 ` Jeff King
2026-06-10 14:21 ` Kristoffer Haugsbakk
2026-06-11 6:56 ` Jeff King
2026-06-11 7:03 ` Kristoffer Haugsbakk
2026-08-02 19:57 ` [PATCH] trailers: stop recognizing URLs as trailers kristofferhaugsbakk
2026-08-02 22:36 ` Junio C Hamano
2026-08-03 12:11 ` Kristoffer Haugsbakk
2026-08-03 15:20 ` Jeff King
2026-08-03 15:39 ` Junio C Hamano [this message]
2026-08-06 20:17 ` Kristoffer Haugsbakk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqtspbz00x.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=code@khaugsbakk.name \
--cc=git@vger.kernel.org \
--cc=kristofferhaugsbakk@fastmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox