From: Junio C Hamano <gitster@pobox.com>
To: "Burak Kaan Karaçay" <bkkaracay@gmail.com>
Cc: git@vger.kernel.org, christian.couder@gmail.com
Subject: Re: [GSOC PATCH v2 0/2] mailmap: reduce global state
Date: Fri, 20 Feb 2026 08:16:17 -0800 [thread overview]
Message-ID: <xmqqtsvbz8z2.fsf@gitster.g> (raw)
In-Reply-To: <20260220060442.29469-1-bkkaracay@gmail.com> ("Burak Kaan Karaçay"'s message of "Fri, 20 Feb 2026 09:04:40 +0300")
Burak Kaan Karaçay <bkkaracay@gmail.com> writes:
> This patch series aims to reduce the global variable dependency of the
> mailmap subsystem:
>
> - Patch 1 eliminates the implicit 'the_repository' dependency in the
> 'read_mailmap' and 'read_mailmap_blob' functions by adding a
> 'struct repository' parameter.
>
> - Patch 2 removes the 'git_mailmap_file' and 'git_mailmap_blob' global
> variables, shifting to on-demand configuration reading via the config
> set helpers and using local variables.
>
> Changes in v2:
> - Forward declare 'struct repository' in mailmap.h
> - Fix whitespace problems
Thanks for a quick reroll. Looking very good.
Will queue.
prev parent reply other threads:[~2026-02-20 16:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-19 12:59 [GSOC PATCH 0/2] mailmap: reduce global state Burak Kaan Karaçay
2026-02-19 12:59 ` [GSOC PATCH 1/2] mailmap: stop using the_repository Burak Kaan Karaçay
2026-02-19 12:59 ` [GSOC PATCH 2/2] mailmap: drop global config variables Burak Kaan Karaçay
2026-02-19 21:22 ` [GSOC PATCH 0/2] mailmap: reduce global state Junio C Hamano
2026-02-19 22:50 ` Junio C Hamano
2026-02-20 6:04 ` [GSOC PATCH v2 " Burak Kaan Karaçay
2026-02-20 6:04 ` [GSOC PATCH v2 1/2] mailmap: stop using the_repository Burak Kaan Karaçay
2026-02-20 6:04 ` [GSOC PATCH v2 2/2] mailmap: drop global config variables Burak Kaan Karaçay
2026-02-20 16:16 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqtsvbz8z2.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=bkkaracay@gmail.com \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox