From: Junio C Hamano <gitster@pobox.com>
To: Toon Claes <toon@iotcl.com>
Cc: git@vger.kernel.org, Jeff King <peff@peff.net>
Subject: Re: [PATCH 1/2] git-compat-util: introduce MEMZERO_ARRAY() macro
Date: Thu, 11 Dec 2025 12:18:39 +0900 [thread overview]
Message-ID: <xmqqtsxxg0z4.fsf@gitster.g> (raw)
In-Reply-To: <20251210-toon-cocci-memzero-v1-1-ae916a79065b@iotcl.com> (Toon Claes's message of "Wed, 10 Dec 2025 14:13:01 +0100")
Toon Claes <toon@iotcl.com> writes:
> +@@
> +- memset(ptr, \( 0x0 \| 0 \), n * \( sizeof(T)
> +- \| sizeof(*ptr)
> +- \) )
> ++ MEMZERO_ARRAY(ptr, n)
Shouldn't we be also catching
memset(array, '\0', sizeof(array[0]) * ARRAY_SIZE(array));
in addition to "0" and "0x0"?
next prev parent reply other threads:[~2025-12-11 3:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-10 13:13 [PATCH 0/2] Add MEMZERO_ARRAY() macro and use it in coccinelle Toon Claes
2025-12-10 13:13 ` [PATCH 1/2] git-compat-util: introduce MEMZERO_ARRAY() macro Toon Claes
2025-12-11 3:18 ` Junio C Hamano [this message]
2025-12-12 13:02 ` René Scharfe
2025-12-19 9:17 ` Toon Claes
2025-12-10 13:13 ` [PATCH 2/2] contrib/coccinelle: pass include paths to spatch(1) Toon Claes
2025-12-11 6:19 ` Patrick Steinhardt
2025-12-12 5:04 ` Junio C Hamano
2025-12-13 1:22 ` Junio C Hamano
2025-12-13 0:18 ` [PATCH 0/2] Add MEMZERO_ARRAY() macro and use it in coccinelle Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqtsxxg0z4.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=toon@iotcl.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).