git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "René Scharfe" <l.s.r@web.de>
Cc: Git List <git@vger.kernel.org>,  Patrick Steinhardt <ps@pks.im>
Subject: Re: [PATCH] config: fix short help of unset flags
Date: Mon, 24 Nov 2025 15:00:08 -0800	[thread overview]
Message-ID: <xmqqtsyjujd3.fsf@gitster.g> (raw)
In-Reply-To: <06997dce-e4d5-4889-8e70-5f44da3dc800@web.de> ("René Scharfe"'s message of "Mon, 24 Nov 2025 22:00:05 +0100")

René Scharfe <l.s.r@web.de> writes:

> The flags --all and --value of "git config unset" don't make the command
> "replace" or "show" anything, they are about selecting what to unset.
> Change their help text accordingly.

Good eyes.  Perfectly makes sense.  Will queue.  Thanks.

>
> Signed-off-by: René Scharfe <l.s.r@web.de>
> ---
>  builtin/config.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/builtin/config.c b/builtin/config.c
> index 86e0cd77f3..80107e61dd 100644
> --- a/builtin/config.c
> +++ b/builtin/config.c
> @@ -1003,8 +1003,8 @@ static int cmd_config_unset(int argc, const char **argv, const char *prefix,
>  	struct option opts[] = {
>  		CONFIG_LOCATION_OPTIONS(location_opts),
>  		OPT_GROUP(N_("Filter")),
> -		OPT_BIT(0, "all", &flags, N_("replace multi-valued config option with new value"), CONFIG_FLAGS_MULTI_REPLACE),
> -		OPT_STRING(0, "value", &value_pattern, N_("pattern"), N_("show config with values matching the pattern")),
> +		OPT_BIT(0, "all", &flags, N_("unset all multi-valued config options"), CONFIG_FLAGS_MULTI_REPLACE),
> +		OPT_STRING(0, "value", &value_pattern, N_("pattern"), N_("unset multi-valued config options with matching values")),
>  		OPT_BIT(0, "fixed-value", &flags, N_("use string equality when comparing values to value pattern"), CONFIG_FLAGS_FIXED_VALUE),
>  		OPT_END(),
>  	};

  reply	other threads:[~2025-11-24 23:00 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-24 21:00 [PATCH] config: fix short help of unset flags René Scharfe
2025-11-24 23:00 ` Junio C Hamano [this message]
2025-12-01  8:11   ` Patrick Steinhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqtsyjujd3.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=l.s.r@web.de \
    --cc=ps@pks.im \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).