* [PATCH] config: fix short help of unset flags
@ 2025-11-24 21:00 René Scharfe
2025-11-24 23:00 ` Junio C Hamano
0 siblings, 1 reply; 3+ messages in thread
From: René Scharfe @ 2025-11-24 21:00 UTC (permalink / raw)
To: Git List; +Cc: Patrick Steinhardt
The flags --all and --value of "git config unset" don't make the command
"replace" or "show" anything, they are about selecting what to unset.
Change their help text accordingly.
Signed-off-by: René Scharfe <l.s.r@web.de>
---
builtin/config.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/builtin/config.c b/builtin/config.c
index 86e0cd77f3..80107e61dd 100644
--- a/builtin/config.c
+++ b/builtin/config.c
@@ -1003,8 +1003,8 @@ static int cmd_config_unset(int argc, const char **argv, const char *prefix,
struct option opts[] = {
CONFIG_LOCATION_OPTIONS(location_opts),
OPT_GROUP(N_("Filter")),
- OPT_BIT(0, "all", &flags, N_("replace multi-valued config option with new value"), CONFIG_FLAGS_MULTI_REPLACE),
- OPT_STRING(0, "value", &value_pattern, N_("pattern"), N_("show config with values matching the pattern")),
+ OPT_BIT(0, "all", &flags, N_("unset all multi-valued config options"), CONFIG_FLAGS_MULTI_REPLACE),
+ OPT_STRING(0, "value", &value_pattern, N_("pattern"), N_("unset multi-valued config options with matching values")),
OPT_BIT(0, "fixed-value", &flags, N_("use string equality when comparing values to value pattern"), CONFIG_FLAGS_FIXED_VALUE),
OPT_END(),
};
--
2.52.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] config: fix short help of unset flags
2025-11-24 21:00 [PATCH] config: fix short help of unset flags René Scharfe
@ 2025-11-24 23:00 ` Junio C Hamano
2025-12-01 8:11 ` Patrick Steinhardt
0 siblings, 1 reply; 3+ messages in thread
From: Junio C Hamano @ 2025-11-24 23:00 UTC (permalink / raw)
To: René Scharfe; +Cc: Git List, Patrick Steinhardt
René Scharfe <l.s.r@web.de> writes:
> The flags --all and --value of "git config unset" don't make the command
> "replace" or "show" anything, they are about selecting what to unset.
> Change their help text accordingly.
Good eyes. Perfectly makes sense. Will queue. Thanks.
>
> Signed-off-by: René Scharfe <l.s.r@web.de>
> ---
> builtin/config.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/builtin/config.c b/builtin/config.c
> index 86e0cd77f3..80107e61dd 100644
> --- a/builtin/config.c
> +++ b/builtin/config.c
> @@ -1003,8 +1003,8 @@ static int cmd_config_unset(int argc, const char **argv, const char *prefix,
> struct option opts[] = {
> CONFIG_LOCATION_OPTIONS(location_opts),
> OPT_GROUP(N_("Filter")),
> - OPT_BIT(0, "all", &flags, N_("replace multi-valued config option with new value"), CONFIG_FLAGS_MULTI_REPLACE),
> - OPT_STRING(0, "value", &value_pattern, N_("pattern"), N_("show config with values matching the pattern")),
> + OPT_BIT(0, "all", &flags, N_("unset all multi-valued config options"), CONFIG_FLAGS_MULTI_REPLACE),
> + OPT_STRING(0, "value", &value_pattern, N_("pattern"), N_("unset multi-valued config options with matching values")),
> OPT_BIT(0, "fixed-value", &flags, N_("use string equality when comparing values to value pattern"), CONFIG_FLAGS_FIXED_VALUE),
> OPT_END(),
> };
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] config: fix short help of unset flags
2025-11-24 23:00 ` Junio C Hamano
@ 2025-12-01 8:11 ` Patrick Steinhardt
0 siblings, 0 replies; 3+ messages in thread
From: Patrick Steinhardt @ 2025-12-01 8:11 UTC (permalink / raw)
To: Junio C Hamano; +Cc: René Scharfe, Git List
On Mon, Nov 24, 2025 at 03:00:08PM -0800, Junio C Hamano wrote:
> René Scharfe <l.s.r@web.de> writes:
>
> > The flags --all and --value of "git config unset" don't make the command
> > "replace" or "show" anything, they are about selecting what to unset.
> > Change their help text accordingly.
>
> Good eyes. Perfectly makes sense. Will queue. Thanks.
Indeed, the patch looks obviously good to me. Thanks for the fixes!
Patrick
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-12-01 8:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-11-24 21:00 [PATCH] config: fix short help of unset flags René Scharfe
2025-11-24 23:00 ` Junio C Hamano
2025-12-01 8:11 ` Patrick Steinhardt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).