Re: [PATCH v7 0/3] Introduce git-last-modified(1) command

[Junio C Hamano <gitster@pobox.com>]

Patrick Steinhardt <ps@pks.im> writes:

> On Tue, Aug 05, 2025 at 11:33:55AM +0200, Toon Claes wrote:
>> Changes in v7:
>> - Fix case when bloom filters were used and a commit range was given. This bug
>>   was uncovered in CI.
>> - Rename the long option for `-t` to `--show-trees`. This option no longer
>>   implies option `-r`. And resemble these changes in the documentation, with a
>>   few other small documentation tweaks.
>> - Move prepare_commit_graph() into get_bloom_filter_settings() which no longer
>>   requires last-modified to worry about it itself. This is similar to
>>   repo_find_commit_pos_in_graph() and lookup_commit_in_graph()
>> - Bring back the call to commit_graph_generation() in maybe_changed_path(). This
>>   is also called in the same function in blame.c and in
>>   check_maybe_different_in_bloom_filter() in revision.c. I couldn't find a test
>>   case that triggers this exit condition, but it should not have negative
>>   side-effects.
>> - No longer call diff_free() on the copy we make when populating the `paths` of
>>   `struct last_modified`. Because we weren't doing a deep copy, this could clean
>>   up fields used later on by the original. Instead only call clear_pathspec(). A
>>   comment to clarify this mechanism better is added.
>> - Add BUG() call to exit condition that shouldn't happen.
>> - Switch some int types to bool types.
>
> This version looks good to me, thanks!

Thanks, both of you.