git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: Seyi Chamber <kuforiji98@gmail.com>,
	 git@vger.kernel.org, phillip.wood@dunelm.org.uk
Subject: Re: [PATCH 1/9] t/unit-tests: adapt lib-reftable{c,h} helper functions to clar
Date: Tue, 29 Apr 2025 08:44:16 -0700	[thread overview]
Message-ID: <xmqqtt677z1r.fsf@gitster.g> (raw)
In-Reply-To: <aBB6vHl5Gmtva7b3@pks.im> (Patrick Steinhardt's message of "Tue, 29 Apr 2025 09:07:40 +0200")

Patrick Steinhardt <ps@pks.im> writes:

> We do want the Git history to be fully bisectable so that it is easy for
> contributors to find out where a specific bug has been introduced. And
> for the history to be bisectable, we must ensure that every single
> commit builds and passes our test suite. You can do that e.g. via `git
> rebase $BASE_COMMIT -x 'make -j$(nproc) test`, which builds and tests
> every single commit in your commit series.
>
> So yes, this should be adapted so that the initial commit introduces the
> new helpers without removing the old helpers yet so that the unit tests
> that haven't yet been converted continue to build and test just fine.

I started writing the same and thought somebody else may have
already responded, and found yours.  Very well said.

Thanks for spelling out the expectations we have in this project and
explaining how to achieve that goal.

  reply	other threads:[~2025-04-29 15:44 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-27 18:53 [PATCH 0/9] t/unit-tests: convert unit-tests to use clar Seyi Kuforiji
2025-04-27 18:53 ` [PATCH 1/9] t/unit-tests: adapt lib-reftable{c,h} helper functions to clar Seyi Kuforiji
2025-04-28 23:27   ` Junio C Hamano
2025-04-29  6:46     ` Seyi Chamber
2025-04-29  7:07       ` Patrick Steinhardt
2025-04-29 15:44         ` Junio C Hamano [this message]
2025-04-27 18:53 ` [PATCH 2/9] t/unit-tests: convert reftable basics test to use clar test framework Seyi Kuforiji
2025-04-27 18:53 ` [PATCH 3/9] t/unit-tests: convert reftable block test to use clar Seyi Kuforiji
2025-04-27 18:53 ` [PATCH 4/9] t/unit-tests: convert reftable merged " Seyi Kuforiji
2025-04-27 18:53 ` [PATCH 5/9] t/unit-tests: convert reftable pq " Seyi Kuforiji
2025-04-27 18:53 ` [PATCH 6/9] t/unit-tests: convert reftable reader " Seyi Kuforiji
2025-04-27 18:53 ` [PATCH 7/9] t/unit-tests: convert reftable readwrite " Seyi Kuforiji
2025-04-27 18:53 ` [PATCH 8/9] t/unit-tests: convert reftable record " Seyi Kuforiji
2025-04-27 18:53 ` [PATCH 9/9] t/unit-tests: convert reftable stack " Seyi Kuforiji

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqtt677z1r.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=kuforiji98@gmail.com \
    --cc=phillip.wood@dunelm.org.uk \
    --cc=ps@pks.im \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).