git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Lucas Seiki Oshiro <lucasseikioshiro@gmail.com>
Cc: git@vger.kernel.org,  Patrick Steinhardt <ps@pks.im>,
	 "D . Ben Knoble" <ben.knoble@gmail.com>
Subject: Re: [GSoC PATCH v2] userdiff: add builtin driver for gitconfig syntax
Date: Mon, 24 Mar 2025 02:43:52 -0700	[thread overview]
Message-ID: <xmqqtt7iojaf.fsf@gitster.g> (raw)
In-Reply-To: <20250324021101.7483-1-lucasseikioshiro@gmail.com> (Lucas Seiki Oshiro's message of "Sun, 23 Mar 2025 23:11:01 -0300")

Lucas Seiki Oshiro <lucasseikioshiro@gmail.com> writes:

> This v2 removes the quoted text from the commit message, using a reference to
> the documentation file and the commit that last changed the lines where it was
> copied before.
>
> I'm also adding the missing newlines at the end of the test files.
>
>  t/t4018/gitconfig-section             | 6 ++++++
>  t/t4018/gitconfig-section-noindent    | 6 ++++++
>  t/t4018/gitconfig-subsection          | 8 ++++++++
>  t/t4018/gitconfig-subsection-noindent | 8 ++++++++
>  userdiff.c                            | 4 ++++
>  5 files changed, 32 insertions(+)
>  create mode 100644 t/t4018/gitconfig-section
>  create mode 100644 t/t4018/gitconfig-section-noindent
>  create mode 100644 t/t4018/gitconfig-subsection
>  create mode 100644 t/t4018/gitconfig-subsection-noindent

.git/rebase-apply/patch:83: indent with spaces.
         "^\\[[a-zA-Z0-9]+\\]|\\[[a-zA-Z0-9]+[ \t]+\".+\"\\]$",
.git/rebase-apply/patch:84: indent with spaces.
         /* -- */
.git/rebase-apply/patch:85: indent with spaces.
         "[^ \t]+"),
warning: 3 lines applied after fixing whitespace errors.
Applying: userdiff: add builtin driver for gitconfig syntax


      parent reply	other threads:[~2025-03-24  9:43 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-24  2:11 [GSoC PATCH v2] userdiff: add builtin driver for gitconfig syntax Lucas Seiki Oshiro
2025-03-24  7:18 ` Johannes Sixt
2025-03-24 20:23   ` D. Ben Knoble
2025-03-25 18:34   ` Lucas Seiki Oshiro
2025-03-24  9:43 ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqtt7iojaf.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=ben.knoble@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=lucasseikioshiro@gmail.com \
    --cc=ps@pks.im \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).