From: Junio C Hamano <gitster@pobox.com>
To: Aryan Pathania <aryan.pathania2003@gmail.com>
Cc: Patrick Steinhardt <ps@pks.im>, git@vger.kernel.org
Subject: Re: [GSoC PATCH] t9400: prefer test_path_* helper functions
Date: Fri, 14 Mar 2025 10:07:40 -0700 [thread overview]
Message-ID: <xmqqtt7vilr7.fsf@gitster.g> (raw)
In-Reply-To: <gm67nhqkoa5adxz5ifckpvecn5f5hewubmcm62nr4hejlwbhsg@pmo472wkj7of> (Aryan Pathania's message of "Fri, 14 Mar 2025 21:00:22 +0900")
Aryan Pathania <aryan.pathania2003@gmail.com> writes:
> Hi Junio, thanks a lot for taking time to review my patch.
>
>>That is exactly Patrick suggested (go back and read it). I agree
>>with him that the updated stronger check is an improvement and it
>>deserves to be explained in the commit message.
> I apologize for miscomunication. I was agreeing with the suggestion.
Sorry for misreading what you wrote. Mistakes happen, so please
don't over-apologize around here ;-)
next prev parent reply other threads:[~2025-03-14 17:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-08 9:03 [GSoC PATCH] t9400: prefer test_path_* helper functions Aryan Pathania
2025-03-10 6:50 ` Patrick Steinhardt
2025-03-12 17:34 ` Aryan Pathania
2025-03-12 18:13 ` Junio C Hamano
2025-03-14 12:00 ` Aryan Pathania
2025-03-14 17:07 ` Junio C Hamano [this message]
2025-03-18 13:10 ` [GSoC PATCH v2] Use `test_path_*` helper functions instead of `test -[efd]` Aryan Pathania
2025-03-18 22:06 ` Eric Sunshine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqtt7vilr7.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=aryan.pathania2003@gmail.com \
--cc=git@vger.kernel.org \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).