From: Junio C Hamano <gitster@pobox.com>
To: phillip.wood123@gmail.com
Cc: David Mandelberg <david@mandelberg.org>,
phillip.wood@dunelm.org.uk,
David Mandelberg via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org, Jacob Keller <jacob.keller@gmail.com>
Subject: Re: [PATCH 3/3] completion: fix bugs with slashes in remote names
Date: Mon, 03 Mar 2025 12:29:56 -0800 [thread overview]
Message-ID: <xmqqtt89vovv.fsf@gitster.g> (raw)
In-Reply-To: <65d903c0-6b4b-4a55-b7e4-4a277417f0f1@gmail.com> (phillip's message of "Mon, 3 Mar 2025 16:36:24 +0000")
phillip.wood123@gmail.com writes:
>> local fer_pids=
>> for ...
>> do
>> __git for-each-ref ... &
>> fer_pids="$fer_pids $!"
>> done
>> test -z "$fer_pids" || wait $fer_pids
>> } | sort | uniq -u
>> That might cause spikes in cpu/memory/disk usage that aren't ideal
>> though.
>
> Yes, if there were a 100 remotes that's a bit of a fork-bomb.
And they are all competing for a shared common resource for read
access.
I wonder if a single invocation of for-each-ref for refs/remotes/
hierarchy would be sufficient? That is, the calling shell script
can set up a shell function "foo" and then
eval $(for-each-ref --format='foo %(refname)' --shell refs/remotes/)
and "foo" can do its thing avoiding as much forks as possible. As
you are allowed bash-ism in completion script, you do not have to
limit yourself to POSIX parameter substitution but can use substring
expansion ${parameter:offset:length} and pattern substitution
${parameter/pattern/string} and other kind of bash exotics, as well
as shell arrays (e.g., define an array __git__remote_branches[] for
each remote, which may contain the remote-tracking branches for the
remote).
next prev parent reply other threads:[~2025-03-03 20:30 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-02 7:45 [PATCH 0/3] completion: fix bugs with slashes in remote names David Mandelberg via GitGitGadget
2025-03-02 7:45 ` [PATCH 1/3] completion: add helper to escape strings for fnmatch David Mandelberg via GitGitGadget
2025-03-02 7:45 ` [PATCH 2/3] completion: add helper to count path components David Mandelberg via GitGitGadget
2025-03-02 7:45 ` [PATCH 3/3] completion: fix bugs with slashes in remote names David Mandelberg via GitGitGadget
2025-03-02 14:17 ` Phillip Wood
2025-03-02 20:34 ` David Mandelberg
2025-03-03 16:36 ` phillip.wood123
2025-03-03 19:19 ` David Mandelberg
2025-03-03 19:43 ` Todd Zullinger
2025-03-06 20:26 ` D. Ben Knoble
2025-03-06 20:24 ` D. Ben Knoble
2025-03-06 20:38 ` Junio C Hamano
2025-03-07 10:34 ` phillip.wood123
2025-03-07 21:46 ` David Mandelberg
2025-03-13 17:40 ` D. Ben Knoble
2025-03-13 20:19 ` David Mandelberg
2025-03-03 20:29 ` Junio C Hamano [this message]
2025-03-03 19:33 ` SZEDER Gábor
2025-03-03 19:49 ` David Mandelberg
2025-03-06 20:46 ` Junio C Hamano
2025-03-07 20:11 ` David Mandelberg
2025-03-07 20:57 ` Junio C Hamano
2025-03-07 21:38 ` David Mandelberg
2025-03-07 21:45 ` Junio C Hamano
2025-03-05 0:07 ` [PATCH v2 0/2] " David Mandelberg
2025-03-05 0:08 ` [PATCH v2 1/2] completion: add helper to count path components David Mandelberg
2025-03-05 0:09 ` [PATCH v2 2/2] completion: fix bugs with slashes in remote names David Mandelberg
2025-03-05 20:50 ` David Mandelberg
2025-03-06 16:35 ` Phillip Wood
2025-03-06 17:12 ` David Mandelberg
2025-03-06 17:39 ` Phillip Wood
2025-03-14 19:40 ` [PATCH v3 0/2] " David Mandelberg
2025-03-14 19:41 ` [PATCH v3 1/2] completion: add helper to count path components David Mandelberg
2025-03-14 19:43 ` [PATCH v3 2/2] completion: fix bugs with slashes in remote names David Mandelberg
2025-03-14 22:18 ` Junio C Hamano
2025-03-14 22:37 ` David Mandelberg
2025-03-14 23:23 ` Junio C Hamano
2025-03-18 17:02 ` Phillip Wood
2025-03-18 17:27 ` Junio C Hamano
2025-03-23 21:04 ` [PATCH v4 0/2] " David Mandelberg
2025-03-23 21:05 ` [PATCH v4 1/2] completion: add helper to count path components David Mandelberg
2025-03-23 21:06 ` [PATCH v4 2/2] completion: fix bugs with slashes in remote names David Mandelberg
2025-04-08 14:18 ` [PATCH v4 0/2] " Phillip Wood
2025-04-08 18:55 ` David Mandelberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqtt89vovv.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=david@mandelberg.org \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=jacob.keller@gmail.com \
--cc=phillip.wood123@gmail.com \
--cc=phillip.wood@dunelm.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).