From: Junio C Hamano <gitster@pobox.com>
To: David Mandelberg <david@mandelberg.org>
Cc: git@vger.kernel.org, "brian m. carlson" <sandals@crustytoothpaste.net>
Subject: Re: [PATCH] editorconfig: add .bash extension
Date: Mon, 03 Mar 2025 08:40:42 -0800 [thread overview]
Message-ID: <xmqqtt8avzhx.fsf@gitster.g> (raw)
In-Reply-To: <15fa4f5d838745b5b05248b44aa16a57@mandelberg.org> (David Mandelberg's message of "Sun, 02 Mar 2025 15:54:44 -0500")
David Mandelberg <david@mandelberg.org> writes:
> Both files in the command below appear to be indented with tabs, and I'd
> expect .bash files to have roughly the same style as .sh files.
>
> $ find . -name \*.bash
> ./contrib/completion/git-completion.bash
> ./ci/check-directional-formatting.bash
>
> Signed-off-by: David Mandelberg <david@mandelberg.org>
> ---
> .editorconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
I love these obviously correct additions ;-)
Thanks.
> diff --git a/.editorconfig b/.editorconfig
> index a3c578a43c..2d3929b591 100644
> --- a/.editorconfig
> +++ b/.editorconfig
> @@ -4,7 +4,7 @@ insert_final_newline = true
>
> # The settings for C (*.c and *.h) files are mirrored in .clang-format. Keep
> # them in sync.
> -[{*.{c,h,sh,perl,pl,pm,txt,adoc},config.mak.*,Makefile}]
> +[{*.{c,h,sh,bash,perl,pl,pm,txt,adoc},config.mak.*,Makefile}]
> indent_style = tab
> tab_width = 8
prev parent reply other threads:[~2025-03-03 16:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-02 20:54 [PATCH] editorconfig: add .bash extension David Mandelberg
2025-03-03 16:40 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqtt8avzhx.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=david@mandelberg.org \
--cc=git@vger.kernel.org \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).