From: Junio C Hamano <gitster@pobox.com>
To: Derrick Stolee <stolee@gmail.com>
Cc: Patrick Steinhardt <ps@pks.im>,
git@vger.kernel.org,
Shubham Kanodia <shubham.kanodia10@gmail.com>
Subject: Re: [PATCH v2] builtin/gc: fix crash when running `git maintenance start`
Date: Wed, 09 Oct 2024 10:28:16 -0700 [thread overview]
Message-ID: <xmqqttdluqxb.fsf@gitster.g> (raw)
In-Reply-To: <26e589c7-7625-409c-9913-9ed4b8ef9808@gmail.com> (Derrick Stolee's message of "Wed, 9 Oct 2024 09:13:47 -0400")
Derrick Stolee <stolee@gmail.com> writes:
> ... But
> a way to rephrase what you mean is "Git has compile-time expectations
> that crontab doesn't exist for macOS and Windows, but Git checks for
> 'systemctl' on the PATH regardless of compiled platform."
>
> Thus, placing a systemctl script works for these platforms even when
> they don't have systemctl available normally.
Very nice rewrite. Thanks for pointing out what your initial
reading hiccupped, as it is likely the same would happen to others.
next prev parent reply other threads:[~2024-10-09 17:28 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-08 10:50 Bug: `git maintenance start` is likely broken in 2.47 Shubham Kanodia
2024-10-08 11:45 ` Patrick Steinhardt
2024-10-08 12:15 ` [PATCH] builtin/gc: fix crash when running `git maintenance start` Patrick Steinhardt
2024-10-08 18:30 ` Derrick Stolee
2024-10-09 2:58 ` Derrick Stolee
2024-10-09 6:28 ` Patrick Steinhardt
2024-10-08 18:33 ` Junio C Hamano
2024-10-09 23:14 ` Junio C Hamano
2024-10-10 4:54 ` Patrick Steinhardt
2024-10-10 5:10 ` Patrick Steinhardt
2024-10-09 7:08 ` [PATCH v2] " Patrick Steinhardt
2024-10-09 13:13 ` Derrick Stolee
2024-10-09 17:28 ` Junio C Hamano [this message]
2024-10-09 17:10 ` Junio C Hamano
2024-10-10 5:33 ` [PATCH v3] " Patrick Steinhardt
2024-10-10 17:09 ` Junio C Hamano
2024-10-14 4:44 ` Shubham Kanodia
2024-10-14 8:38 ` Patrick Steinhardt
2024-10-15 0:36 ` Taylor Blau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqttdluqxb.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=ps@pks.im \
--cc=shubham.kanodia10@gmail.com \
--cc=stolee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).