From: Junio C Hamano <gitster@pobox.com>
To: Dragan Simic <dsimic@manjaro.org>
Cc: "Rubén Justo" <rjusto@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH] doc: note that interactive.singleKey is disabled by default
Date: Wed, 22 May 2024 13:45:30 -0700 [thread overview]
Message-ID: <xmqqttip379x.fsf@gitster.g> (raw)
In-Reply-To: <54c318f42ce63f0575ea48f3dc1e8361@manjaro.org> (Dragan Simic's message of "Wed, 22 May 2024 20:52:43 +0200")
Dragan Simic <dsimic@manjaro.org> writes:
> interactive.singleKey
> If true, allow the user to provide one-letter input with a
> single key (i.e., without hitting Enter key) in interactive
> commands.
> [...]
>
> Thoughts? It would be more consistent and a bit more clear, without
> putting too much stress on the actual default value.
"When set to true" or "when configured to true" is much better than
"defaults to true".
I am ambivalent about "If true", though. It still leaves it open
for some mysterious "default" mechanism giving the value true
without user doing anything explicitly.
next prev parent reply other threads:[~2024-05-22 20:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-22 7:34 [PATCH] doc: note that interactive.singleKey is disabled by default Dragan Simic
2024-05-22 17:31 ` Rubén Justo
2024-05-22 18:28 ` Junio C Hamano
2024-05-22 18:52 ` Dragan Simic
2024-05-22 20:45 ` Junio C Hamano [this message]
2024-05-22 20:50 ` Dragan Simic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqttip379x.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=dsimic@manjaro.org \
--cc=git@vger.kernel.org \
--cc=rjusto@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).